Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report absolute consumer and topic offsets #4

Merged
merged 2 commits into from
May 2, 2019
Merged

Conversation

Fiveside
Copy link

There's actually a couple pieces here:

  • Thread the last bit of the info collection
  • Report absolute consumer group position
  • Report latest partition offsets
  • Only collect stats for topics that a consumer group is actually tracking

…group position, report latest partition offsets, only collect stats for topics that a consumer group is actually tracking
@Fiveside Fiveside requested a review from tshedor April 23, 2019 21:01
go func(grp string) {
defer wg.Done()
response, err := admin.ListConsumerGroupOffsets(grp, partitions)
log.Debug("admin.ListConsumerGroups(%s, nil) = %v, %v", grp, response, err)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still necessary?

Copy link

@tshedor tshedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is officially over my head, but I see you're tracking consumer lag and offset, and partition offset, and that's good.

@Fiveside Fiveside merged commit 132fff6 into master May 2, 2019
@Fiveside Fiveside deleted the limit-groups branch May 2, 2019 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants