Switch back to kingpin for arg parsing #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
April 4, 2019 16:53
tshedor
reviewed
Apr 8, 2019
| opts = append(opts, statsd.TagsFormat(tagFormat)) | ||
| } | ||
|
|
||
| return statsd.New(opts...) |
There was a problem hiding this comment.
Should this be statsd.New(), nil or does statsd.New return an (instance, error) itself?
There was a problem hiding this comment.
statsd.New returns (instance, error)
| stats.Gauge(fmt.Sprintf("consumer_lag,%s", strings.Join(tags, ",")), lag) | ||
| stats := statsdClient.Clone( | ||
| statsd.Tags("topic", topic), | ||
| statsd.Tags("partition", strconv.FormatInt(int64(partitionID), 10)), |
There was a problem hiding this comment.
Is there any risk of this throwing? Say partitionID is nil?
There was a problem hiding this comment.
partitionID is an int32. Int32 isn't a pointer, so it can't be nil. This is just doing a int->str conversion.
| tags = append(tags, fmt.Sprintf("partition=%d", partitionID)) | ||
| tags = append(tags, "consumer_group="+cg) | ||
| stats.Gauge(fmt.Sprintf("consumer_lag,%s", strings.Join(tags, ",")), lag) | ||
| stats := statsdClient.Clone( |
There was a problem hiding this comment.
Yes, go is a garbage collected language. The cloned client also doesn't need to be .Close()d because when the main client is closed, all cloned clients are also closed.
tshedor
approved these changes
Apr 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It allows for parameter passing via environment variables.
Also hit it with that
go mod tidyto get rid of some of the unused dependencies.