Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix headerlink CSS class #16

Merged
merged 1 commit into from
Feb 24, 2020
Merged

Fix headerlink CSS class #16

merged 1 commit into from
Feb 24, 2020

Conversation

lgeiger
Copy link
Contributor

@lgeiger lgeiger commented Feb 24, 2020

nbconvert uses the anchor-link class name for anchor links where as mkdocs uses a headerlink class name.

This change converts the anchor-link class to headerlink to fix the CSS. I'm not sure if this can be done in a better way, but for now this should work.

@lgeiger lgeiger mentioned this pull request Feb 24, 2020
Closed
@lgeiger lgeiger requested a review from greenape February 24, 2020 17:23
greenape
greenape approved these changes Feb 24, 2020
View reviewed changes
Copy link
Owner

@greenape greenape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@greenape greenape merged commit e8d62ec into greenape:master Feb 24, 2020
@lgeiger lgeiger deleted the fix-headerlinks branch February 24, 2020 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greenape greenape greenape approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lgeiger @greenape