Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image parsing failed #90

Closed
lanking520 opened this issue Oct 12, 2020 · 7 comments
Closed

Image parsing failed #90

lanking520 opened this issue Oct 12, 2020 · 7 comments
Labels
bug Something isn't working

Comments

@lanking520
Copy link

after upgrade to 0.6.1 with latest nbconvert. It seemed the image parsing has failed:

http://docs.djl.ai/jupyter/load_mxnet_model.html

This is a generated html where you can see some image below are displayed incorrectly.

You can try to run online through clicking the button above and image seemed rendered fine in the notebook itself.

@greenape greenape added the bug Something isn't working label Oct 13, 2020
@greenape
Copy link
Owner

Looks like the tag is getting escaped, I'll jiggle the template around again. 👍

@lanking520
Copy link
Author

It crashed my search engine to grab for search. Getting back to previous version also didn't help much. Here is my current workaround:

nbconvert==5.6.1 mkdocs mkdocs-exclude mknotebooks==0.4.1 mkdocs-material jupyter Pygments Markdown==3.2.2

This combination temporaily work for now. But I guess things might break sooner if jupyter and other packages has an update

@lanking520
Copy link
Author

Since the nbconvert update very fast (they iterate 5 minor versions in the past month), I would recommend mknotebooks to stick on a certain version of it

@greenape
Copy link
Owner

Argh. Yeah, there were substantial changes in the last midpoint releases of nbconvert and markdown which are combining to make this all a bit awkward. Ideally I'd like to avoid pinning to specific versions, but it may be necessary if I can't work out what's going on/keep up with the changes to the nbconvert templating and markdown's parsing.

@greenape
Copy link
Owner

Ok - looks like Python-Markdown/markdown#1044 will fix this, plus several other parsing issues. Once there's a release of markdown which incorporates it, I'll repin and make any tweaks to the template necessary to get things back in order.

greenape added a commit that referenced this issue Oct 20, 2020
@greenape
Copy link
Owner

(Hopefully this is now fixed.)

@lanking520
Copy link
Author

@greenape Thanks, will try today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants