-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hackathon team48.7twh wokier trycatch #15
base: main
Are you sure you want to change the base?
Hackathon team48.7twh wokier trycatch #15
Conversation
wokier
commented
Apr 6, 2023
- Added label 'eco-design' on java:S1696 'Avoid catching NullPointerException.'
- Improved documentation on tag install tooling
…because it is more efficient to use a logical test
Hi @wokier, first of all, thank you for your PR. unfortunately, there is already an existing PR about the same subject : #18 this is a PR that purpose is to refactor this tagging system to make it more automatic : start from a markdown file to put tags to native SonarQube rules. Sorry but I'm reviewing this PR #18. On the other hand, actually, rules list in _config.sh file are only here for my tests. this system is not running yet. I modified this PR to make it "draft in progress" waiting for the other PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as explained, we are waiting for #17 to integrate your modifications
|
||
1. change configuration in `_config.sh` file : check requirements above | ||
2. launch `check_tags.sh` to control your rules and tags | ||
3. launch `install_tag.sh` to add custom tag to your rules (change SIMULATION=0 in configration to do real calls) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo error
|
||
# list of rule keys that will be updated with new tag | ||
RULES_KEYS=css:S4655,php:S2014,Web:ItemTagNotWithinContainerTagCheck | ||
RULES_KEYS=css:S4655,php:S2014,Web:ItemTagNotWithinContainerTagCheck,java:S1696 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please keep only your rule java:S1696
(other rules are only for testing the system
Hi @wokier, why do you want to add this rule "java:S1696 'Avoid catching NullPointerException.'" to the list ? (now the rule is "NullPointerException" should not be caught") |