Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restoring-window view and automatic save points russian translation #858

Conversation

Jollfye
Copy link
Contributor

@Jollfye Jollfye commented Feb 7, 2019

Made "js_history_window" and "js_history_tab" to start with capital letter according with latest English changes here, in "js_session_save_point" used russian word restore by analogy with Windows automatic restore points but original is ok too, waiting on ur opinions.

src/_locales/ru/messages.json Outdated Show resolved Hide resolved
@AlexWayfer
Copy link
Contributor

@deanoemcke, maybe "js_session_save_point": { "message": "Automatic save point for v" } should be "Automatic save point for version " for more obvious.

@Jollfye
Copy link
Contributor Author

Jollfye commented Feb 7, 2019

@deanoemcke, maybe "js_session_save_point": { "message": "Automatic save point for v" } should be "Automatic save point for version " for more obvious.

@AlexWayfer hmm to me current "...v" seems ok, it' shorter, minimalistic, I like it that way, but I get ur point when even Chrome on the page chrome://settings/help uses full word "version"

@AlexWayfer
Copy link
Contributor

@AlexWayfer hmm to me current "...v" seems ok, it' shorter, minimalistic, I like it that way

Maybe then in Russian we should use "Автоматическая точка восстановления для вер." 🤷‍♂️

but I get ur point when even Chrome on the page chrome://settings/help uses full word "version"

Not bad.

Also, I'm interested now, how it looks in Chrome in Russian (I'm using English as system language).

@Jollfye
Copy link
Contributor Author

Jollfye commented Feb 7, 2019

@AlexWayfer me too + I'm also interested, maybe I'll give it a try to see in action 😅 And I like ur suggestion to use contraction for russian version but I'm not sure, let's wait for @MonsterNya, what he may say here

@AlexWayfer
Copy link
Contributor

And I like ur suggestion to use contraction for russian version but I'm not sure, let's wait for @MonsterNya, what he may say here

Just a note for English-speakers: для вер. is equal to for ver.

в (like v) is not common in Russian for versions.

So, I suggested the complete form of a word: version/версии

@deanoemcke
Copy link
Collaborator

@AlexWayfer I'm ok with using the complete word version

@MonsterNya
Copy link
Contributor

I came after the party ended, but I am pleased with the way she went ^_^

@Jollfye
Copy link
Contributor Author

Jollfye commented Feb 8, 2019

Alright then, let's leave "js_session_save_point": { "message": "Автоматическая точка восстановления для версии " } as is in russian, and @deanoemcke may change English if he's ok with it. Aand I guess that's it with this PR here.

@AlexWayfer
Copy link
Contributor

Alright then, let's leave "js_session_save_point": { "message": "Автоматическая точка восстановления для версии " } as is in russian, and @deanoemcke may change English if he's ok with it. Aand I guess that's it with this PR here.

I agree.

@deanoemcke deanoemcke merged commit 20b2a51 into greatsuspender:feature/internationalised-restore-view Feb 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants