Suspended Google Docs and Sheets icons show Slides favicon instead

[fwextensions]

After pulling v155 from master, I'm seeing a strange new bug where suspended Google Docs and Sheets documents show the Slides icon instead:

It's a bit transparent, but the tooltip shows that it's a Google Doc tab. Only 5 of the tabs in the screenshot are actually presentations. The rest are documents and spreadsheets. Only one open Google Sheets tab is suspended and showing the correct icon. Not sure what's special about that tab.

Did something change about how TGS is pulling favicons?

• Extension version: 7.0.155
• Browser name & version: Chrome 71
• Operating system & version: Windows 10

[fwextensions]

I just manually suspended a Google Doc and it showed the correct favicon. I believe all the ones with the wrong icons were auto-suspended and recovered after I restarted the extension. I haven't restarted Chrome since, so maybe it's in a weird state. I haven't noticed any other incorrect favicons.

[fwextensions]

I've since restarted my machine and now the logos are incorrectly showing Doc icons instead of Sheets:

Some of those tabs are spreadsheets and presentations but they all look like documents.

Is the new favicon handling only looking at domains and using the same favicon if the domains are the same? They're all docs.google.com, and differ only in the root of the path, so that approach won't work for Google Docs and likely other sites as well.

[zen2go]

In Chromium-based Brave browser beta (Version 0.59.12 Chromium: 72.0.3626.17 (Official Build) beta (64-bit)) all favicons on suspended tabs have disappeared, replaced by a default white document page icon.

This makes it very difficult to find a tab without rolling the cursor over the icons to see the page title hints.

[deanoemcke]

@fwextensions yes, there is some domain level favicon caching which explains the issue. i've just pushed a fixed for this (v7.0.159).

[deanoemcke]

@zen2go is this a session that you've imported from a different browser? the white document page icon will show if chrome does not have a favicon for the tab url in it's cache. so alternatively, possibly you've cleared the cache of the browser?

i have tested with brave and it behaves normally for me.

[fwextensions]

@deanoemcke I pulled 159 and this looks fixed. Before and after shots: