Atomically check transceiver mode and sequence before loop dispatch.

This ensures that when one of the mode-specific loops starts, the choice
of loop and the sequence number passed to it are those set by the same
call to the set_transceiver_mode vendor request handler.

If the handler is called a second time during dispatch, the mode and
sequence numbers it sets will not yet take effect. The already selected
loop will begin running, and will return as soon as it notices the
sequence number has changed.

This avoids any race in which the vendor request handler is called in
between reading the two variables, causing the wrong loop to be started
or to fail to exit when needed.

firmware/hackrf_usb/hackrf_usb.c

@@ -263,15 +263,29 @@ int main(void) {
 	operacake_init(operacake_allow_gpio);
 
 	while(true) {
-		switch (transceiver_mode()) {
+
+		// Briefly disable USB interrupt so that we can
+		// atomically retrieve both the transceiver mode
+		// and the mode change sequence number. They are
+		// changed together by the set_transceiver_mode
+		// vendor request handler.
+
+		nvic_disable_irq(NVIC_USB0_IRQ);
+
+		transceiver_mode_t mode = transceiver_mode();
+		uint32_t seq = transceiver_mode_seq();
+
+		nvic_enable_irq(NVIC_USB0_IRQ);
+
+		switch (mode) {
 		case TRANSCEIVER_MODE_RX:
-			rx_mode();
+			rx_mode(seq);
 			break;
 		case TRANSCEIVER_MODE_TX:
-			tx_mode();
+			tx_mode(seq);
 			break;
 		case TRANSCEIVER_MODE_RX_SWEEP:
-			sweep_mode();
+			sweep_mode(seq);
 			break;
 		case TRANSCEIVER_MODE_CPLD_UPDATE:
 			cpld_update();

firmware/hackrf_usb/usb_api_sweep.c

@@ -87,8 +87,7 @@ usb_request_status_t usb_vendor_request_init_sweep(
 	return USB_REQUEST_STATUS_OK;
 }
 
-void sweep_mode(void) {
-	uint32_t seq = transceiver_mode_seq();
+void sweep_mode(uint32_t seq) {
 	unsigned int blocks_queued = 0;
 	unsigned int phase = 1;
 	bool odd = true;

firmware/hackrf_usb/usb_api_sweep.h

@@ -34,6 +34,6 @@ enum sweep_style {
 usb_request_status_t usb_vendor_request_init_sweep(
 	usb_endpoint_t* const endpoint, const usb_transfer_stage_t stage);
 
-void sweep_mode(void);
+void sweep_mode(uint32_t seq);
 
 #endif /* __USB_API_SWEEP_H__ */

firmware/hackrf_usb/usb_api_transceiver.c

@@ -331,8 +331,7 @@ usb_request_status_t usb_vendor_request_set_hw_sync_mode(
 	}
 }
 
-void rx_mode(void) {
-	uint32_t seq = _transceiver_mode_seq;
+void rx_mode(uint32_t seq) {
 	unsigned int phase = 1;
 
 	baseband_streaming_enable(&sgpio_config);
@@ -361,8 +360,7 @@ void rx_mode(void) {
 	}
 }
 
-void tx_mode(void) {
-	uint32_t seq = _transceiver_mode_seq;
+void tx_mode(uint32_t seq) {
 	unsigned int phase = 1;
 
 	memset(&usb_bulk_buffer[0x0000], 0, 0x8000);

firmware/hackrf_usb/usb_api_transceiver.h

@@ -60,7 +60,7 @@ transceiver_mode_t transceiver_mode(void);
 uint32_t transceiver_mode_seq(void);
 void set_transceiver_mode(const transceiver_mode_t new_transceiver_mode);
 void start_streaming_on_hw_sync();
-void rx_mode(void);
-void tx_mode(void);
+void rx_mode(uint32_t seq);
+void tx_mode(uint32_t seq);
 
 #endif/*__USB_API_TRANSCEIVER_H__*/