Fix ZLP bug on CONTROL IN transfers #115
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cynthion requires the length field of any CONTROL IN transfer request in order to negotiate the transfer acknowledgement successfully.
This PR extends the Facedancer backend API as well as the core implementation to:
USBDevice
method:control_send(self, endpoint_number: int, in_request: USBControlRequest, data: bytes, *, blocking: bool = False)
send_on_control_endpoint(self, endpoint_number: int, in_request: USBControlRequest, data: bytes, blocking: bool=True)
USBControlRequest
to be modified by filters in USB Proxy or custom control handlers in Facedancer devices.Depends on: greatscottgadgets/cynthion#183
Closes #90