Merge branch 'mrh1997-getdescreq-fix' into antoinevg/facedancer-v3

facedancer/device.py

@@ -23,6 +23,7 @@
 
 from .descriptor    import USBDescribable, USBDescriptor, StringDescriptorManager
 from .configuration import USBConfiguration
+from .interface     import USBInterface
 from .endpoint      import USBEndpoint
 from .request       import USBControlRequest, USBRequestHandler
 from .request       import standard_request_handler, to_device, get_request_handler_methods
@@ -715,8 +716,10 @@ def get_string_descriptor(self, index:int) -> bytes:
         else:
             return self.strings[index]
 
-
-    def handle_generic_get_descriptor_request(self, request: USBControlRequest):
+    @staticmethod
+    def handle_generic_get_descriptor_request(
+            descriptor_container:Union['USBDevice', USBInterface],
+            request: USBControlRequest):
         """ Handle GET_DESCRIPTOR requests; per USB2 [9.4.3] """
 
         logging.debug(f"received GET_DESCRIPTOR request {request}")
@@ -726,7 +729,7 @@ def handle_generic_get_descriptor_request(self, request: USBControlRequest):
         descriptor_index = request.value_low
 
         # Try to find the descriptor associate with the request.
-        response = self.descriptors.get(descriptor_type, None)
+        response = descriptor_container.descriptors.get(descriptor_type, None)
 
         # If we have a callable, we need to evaluate it to figure
         # out what the actual descriptor should be.
@@ -813,7 +816,7 @@ def handle_get_descriptor_request(self, request):
         """ Handle GET_DESCRIPTOR requests; per USB2 [9.4.3] """
 
         # Defer to our generic get_descriptor handler.
-        self.handle_generic_get_descriptor_request(request)
+        self.handle_generic_get_descriptor_request(self, request)
 
 
 

facedancer/endpoint.py

@@ -185,7 +185,7 @@ def get_identifier(self) -> int:
 
     def matches_identifier(self, other:int) -> bool:
         # Use only the MSB and the lower nibble; per the USB specification.
-        masked_other = 0b10001111
+        masked_other = other & 0b10001111
         return self.get_identifier() == masked_other
 
 

facedancer/interface.py

@@ -201,9 +201,8 @@ def handle_get_descriptor_request(self, request):
         """ Handle GET_DESCRIPTOR requests; per USB2 [9.4.3] """
         logging.debug("Handling GET_DESCRIPTOR on endpoint.")
 
-        # This is the same as the USBDevice get descriptor request;
-        # delegate to its unbound method to avoid duplication.
-        device.USBDevice.handle_generic_get_descriptor_request(self, request)
+        # This is the same as the USBDevice get descriptor request => avoid duplication.
+        self.get_device().handle_generic_get_descriptor_request(self, request)
 
 
     # Table 9-12 of USB 2.0 spec (pdf page 296)

facedancer/request.py

@@ -170,7 +170,7 @@ def to_any_endpoint(func):
 
 def to_this_interface(func):
     """ Decorator; refines a handler so it's only called on requests targeting this interface. """
-    return _wrap_with_field_matcher(func, 'recipient', USBRequestRecipient.INTERFACE)
+    return _wrap_with_field_matcher(func, 'recipient', USBRequestRecipient.INTERFACE, match_index=True)
 
 def to_any_interface(func):
     """ Decorator; refines a handler so it's only called on requests with an interface recipient. """