Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update udev rules #115

Merged
merged 1 commit into from
Jul 5, 2024
Merged

Update udev rules #115

merged 1 commit into from
Jul 5, 2024

Conversation

mossmann
Copy link
Member

@mossmann mossmann commented Jul 3, 2024

  • Remove legacy VID/PIDs
  • Remove pid.codes test PIDs, supplied by LUNA
  • Update symlink names

This eliminates overlap of the udev rules supplied by Cynthion, LUNA, and Apollo. See also:

@mossmann mossmann requested a review from antoinevg July 3, 2024 12:43
@antoinevg
Copy link
Member

antoinevg commented Jul 3, 2024

I think we should leave these alone in this repo.

My reasoning is that I don't think we should make folk who are not going to be using cynthion to install the udev rules go digging through other repos to figure out what all should be in there.

A second option would be to delete the entire file & directory and instead add the contents to the documentation, but I personally prefer just leaving them as is.

Ummm… wait, better idea -- see comment below.

@antoinevg
Copy link
Member

This file&directory should simply be deleted and moved to the /cynthion/python/assets/ directory as I need it in there anyway for the cynthion udev installation. 🙈

@mossmann
Copy link
Member Author

mossmann commented Jul 3, 2024

Part of my reasoning for eliminating LUNA and Apollo udev rules is that the LUNA and Apollo rules can be added to the assets when building the package (as is to be done for Apollo firmware). We want cynthion to be able to install rules for those dependencies as a convenience to the user, but we don't want the rules to overlap if folks are installing them manually.

A particular case I'm concerned about is distro packaging. With something like apt install apollo, I would want the Apollo udev rules installed. With apt install cynthion, I would want the Apollo and LUNA packages brought in as dependencies, each with their own udev rules.

@mossmann
Copy link
Member Author

mossmann commented Jul 3, 2024

This file&directory should simply be deleted and moved to the /cynthion/python/assets/ directory as I need it in there anyway for the cynthion udev installation. 🙈

I see you've approved, but would you like me to move the rules to /cynthion/python/assets/ before we merge?

@antoinevg
Copy link
Member

Ugh, yes please!

- Remove legacy VID/PIDs
- Remove pid.codes test PIDs supplied by LUNA
- Add pid.codes test PIDs unique to Cynthion
- Update symlink names
- Move to cynthion/python/assets
@mossmann mossmann requested review from antoinevg and removed request for antoinevg July 4, 2024 20:15
@mossmann mossmann merged commit 11184b3 into greatscottgadgets:main Jul 5, 2024
18 checks passed
@mossmann mossmann deleted the udev branch July 5, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants