-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli: add flash-fast command #25
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if it makes sense to review this while greatscottgadgets/luna#220 is still in draft, since the two go together.
In fact, perhaps that flash bridge gateware should live here in the Apollo repository rather than in the LUNA repo?
True, let's wait until that other PR is ready (I'm marking as draft to avoid confusion). I would like to create a PR with the I do not have a strong opinion on the location of the flash bridge gateware. If we decide the code belongs here, I'm willing to move it. |
There's three parts as I see it:
|
Rebased.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested this on cynthion-test
and it's all working great, but I have a couple of comments where we may need to discuss what we want to do.
This command uses a gateware Flash Bridge to access the configuration SPI memory behind the FPGA.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good!
This PR adds a command to Apollo CLI (
apollo flash-fast
) for flash programming. This command first programs a gateware SPI bridge to the FPGA and then uses it to access the configuration SPI flash.