[MAINTENANCE] Enforce consistent JSON schema through usage stats #4499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for niobium-lead-7998 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
cdkini
commented
Mar 22, 2022
Comment on lines
-262
to
+264
| "$schema": "https://json-schema.org/schema#", | ||
| "$schema": SCHEMA, |
There was a problem hiding this comment.
This minor deviation was causing an issue and defaulting to the latest schema (which is version 8 or so?). This was caught during the War on Warnings.
There was a problem hiding this comment.
Note that JSONSchema doesn't love HTTPS in these keys for some reason - following the docs, I kept the HTTP consistent.
…_expectations into maintenance/ensure-consistent-schema-in-usage-stats
…ttps://github.com/great-expectations/great_expectations into maintenance/ensure-consistent-schema-in-usage-stats
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please annotate your PR title to describe what the PR does, then give a brief bulleted description of your PR below. PR titles should begin with [BUGFIX], [FEATURE], [DOCS], or [MAINTENANCE]. If a new feature introduces breaking changes for the Great Expectations API or configuration files, please also add [BREAKING]. You can read about the tags in our contributor checklist.
Changes proposed in this pull request:
Definition of Done
Please delete options that are not relevant.
Thank you for submitting!