Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Update Expectation conditions docs #10661

Open
wants to merge 45 commits into
base: develop
Choose a base branch
from

Conversation

NathanFarmer
Copy link
Contributor

@NathanFarmer NathanFarmer commented Nov 13, 2024

See the changes by checking out the latest netlify "Deploy Preview" below

  • Update docs language for Expectation conditions
  • Provide separate examples for pandas, Spark, and SQL in all cases

  • Description of PR changes above includes a link to an existing GitHub issue
  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Code is linted - run invoke lint (uses ruff format + ruff check)
  • Appropriate tests and docs have been updated

@NathanFarmer NathanFarmer self-assigned this Nov 13, 2024
Copy link

netlify bot commented Nov 13, 2024

Deploy Preview for niobium-lead-7998 canceled.

Name Link
🔨 Latest commit e2a2c27
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/6737b4177ff78e000817643c

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.47%. Comparing base (dca5a61) to head (e2a2c27).
Report is 5 commits behind head on develop.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #10661   +/-   ##
========================================
  Coverage    80.47%   80.47%           
========================================
  Files          462      462           
  Lines        40111    40111           
========================================
  Hits         32279    32279           
  Misses        7832     7832           
Flag Coverage Δ
3.10 68.17% <ø> (ø)
3.11 68.16% <ø> (ø)
3.12 68.17% <ø> (+0.01%) ⬆️
3.12 athena or openpyxl or pyarrow or project or sqlite or aws_creds 55.49% <ø> (ø)
3.12 aws_deps 46.14% <ø> (ø)
3.12 big 54.74% <ø> (ø)
3.12 databricks 48.08% <ø> (+0.20%) ⬆️
3.12 filesystem 61.71% <ø> (ø)
3.12 mssql 51.49% <ø> (ø)
3.12 mysql 51.55% <ø> (ø)
3.12 postgresql 54.62% <ø> (ø)
3.12 snowflake 48.85% <ø> (ø)
3.12 spark 58.07% <ø> (ø)
3.12 spark_connect 46.44% <ø> (ø)
3.12 trino 52.67% <ø> (ø)
3.9 68.19% <ø> (+0.17%) ⬆️
3.9 athena or openpyxl or pyarrow or project or sqlite or aws_creds 55.49% <ø> (-0.07%) ⬇️
3.9 aws_deps 46.16% <ø> (-0.01%) ⬇️
3.9 big 54.76% <ø> (-0.01%) ⬇️
3.9 clickhouse 43.03% <ø> (+0.01%) ⬆️
3.9 databricks 48.10% <ø> (+0.18%) ⬆️
3.9 filesystem 61.73% <ø> (-0.05%) ⬇️
3.9 mssql 51.47% <ø> (-0.05%) ⬇️
3.9 mysql 51.54% <ø> (-0.05%) ⬇️
3.9 postgresql 54.60% <ø> (-0.07%) ⬇️
3.9 snowflake 48.87% <ø> (-0.03%) ⬇️
3.9 spark 58.04% <ø> (-0.09%) ⬇️
3.9 spark_connect 46.45% <ø> (-0.01%) ⬇️
3.9 trino 52.66% <ø> (-0.05%) ⬇️
cloud 0.00% <ø> (ø)
docs-basic 53.40% <ø> (+0.11%) ⬆️
docs-creds-needed 52.97% <ø> (+0.11%) ⬆️
docs-spark 52.46% <ø> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NathanFarmer NathanFarmer changed the title Update Expectation conditions docs [DOCS] Update Expectation conditions docs Nov 13, 2024
@NathanFarmer NathanFarmer marked this pull request as ready for review November 13, 2024 21:47
@NathanFarmer NathanFarmer changed the base branch from develop to m/ph-1627/row-conditions-api November 14, 2024 15:03
@NathanFarmer NathanFarmer force-pushed the d/ph-1627/update-row-condition-docs branch from 87d05bc to 62f0ac2 Compare November 14, 2024 15:26
@NathanFarmer NathanFarmer marked this pull request as ready for review November 14, 2024 15:57
@NathanFarmer NathanFarmer changed the base branch from m/ph-1627/row-conditions-api to develop November 14, 2024 22:09
@NathanFarmer NathanFarmer marked this pull request as draft November 14, 2024 22:10
@NathanFarmer NathanFarmer marked this pull request as ready for review November 14, 2024 23:36
@@ -308,7 +308,7 @@ jobs:
# We decided to exclude all external HTTP requests but the ones that under the domain greatexpectations.io
# The reason is to avoid having network errors such as pages that throw 429 after too many requests (like Github)
# and to prevent other possible errors related to user agent or lychee capturing hrefs from metadata that don't resolve to a specific page (preconnects in JS)
args: "--exclude='http.*' --include='^https://(.+\\.)?greatexpectations\\.io/' 'docs/docusaurus/build/**/*.html'"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a workaround due to limitations of the new link checker. It doesn't know how to check new pages. I will put in a follow-up PR reverting this one line change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant