-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Update Expectation conditions docs #10661
base: develop
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for niobium-lead-7998 canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## develop #10661 +/- ##
========================================
Coverage 80.47% 80.47%
========================================
Files 462 462
Lines 40111 40111
========================================
Hits 32279 32279
Misses 7832 7832
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
87d05bc
to
62f0ac2
Compare
This reverts commit 6f67e83.
This reverts commit b681498.
@@ -308,7 +308,7 @@ jobs: | |||
# We decided to exclude all external HTTP requests but the ones that under the domain greatexpectations.io | |||
# The reason is to avoid having network errors such as pages that throw 429 after too many requests (like Github) | |||
# and to prevent other possible errors related to user agent or lychee capturing hrefs from metadata that don't resolve to a specific page (preconnects in JS) | |||
args: "--exclude='http.*' --include='^https://(.+\\.)?greatexpectations\\.io/' 'docs/docusaurus/build/**/*.html'" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a workaround due to limitations of the new link checker. It doesn't know how to check new pages. I will put in a follow-up PR reverting this one line change.
See the changes by checking out the latest netlify "Deploy Preview" below
invoke lint
(usesruff format
+ruff check
)