Make gelf compactable with ruby-2.4.0 #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tessie Thanks for your contribution! Please sign the CLA for this repository at https://cla-assistant.io/graylog-labs/gelf-rb?pullRequest=55 so that we can merge this PR. Also, please add Ruby 2.4.0 to the |
|
|
|
@joschi I have actually signed the CLA agreement. But it is still showing pending. Can you please help me |
|
Thanks @joschi Signed the CLA also. There was an issue with email id associated with commit.This is fixed |
joschi
approved these changes
Aug 14, 2017
|
:) |
kwatson
added a commit
to kwatson/gelf-rb
that referenced
this pull request
Dec 4, 2017
* 'master' of https://github.com/graylog-labs/gelf-rb: Prevent mutation of notifier arguments Add Ruby 2.4 to list of supported Ruby versions (graylog-labs#60) Make library compatible with Ruby 2.4.0 (graylog-labs#55) Update links in README.md Add additional non-Ruby logger levels for wider compatibility (graylog-labs#52) Opportunistically use Yajl for json encoding (graylog-labs#53) Update .travis.yml to use actual repository (graylog-labs#58)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In ruby 2.4.0
FixNum is deprciated
Also json (1.8.3) is not compatible with 2.4.0