-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds tagged logging support and Logger::Formatter support #23
Conversation
Added formatter to logger
Wow, I can commit via web interface on iPad from a train!
Add more rubies to Travis-CI config
fixes chunking for subclasses of GELF::Notifier
thx for the hint, @edmundoa :) fixes graylog-labs#13
Use default facility if progname is blank
This adds some basic API information to the README file, which didn't have any documentation about the API before. Some parts are copied from the wiki.
Add basic API usage information to README
Thanks for contributing to this project! To continue merging this PR, we need you to sign our Individual Contributor Assignment Agreement as described in https://www.graylog.org/contributing-to-graylog/ @meltingice Would you mind cleaning up those commits a little bit and rebase to current master? There are some unintended changes in this PR, like the unresolved conflicts in |
Seems like this is partly a duplicate of #35 now. Also, besides history cleanup, would you mind creating separate PRs for formatter support and tagged logging? |
@milgner I would like to close this PR - CLA is still beding and this is kind of outdated and might need some love. How would you decide? |
As if the missing CLA i'll close this PR now |
Builds on @mitnal's PR, which adds tagged logging support, and also adds support for logger formatters.