Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(design)!: convert prefix and suffix directives to standalone #3384

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

xelaint
Copy link
Member

@xelaint xelaint commented Dec 30, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Fixes: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[x] Yes
[ ] No

BREAKING CHANGE: daffPrefixableMixin, daffSuffixableMixin, DaffPrefixable, and DaffSuffixable have been removed as they are unnecessary to the usage of prefix and suffix. You can use the DaffPrefixDirective and DaffSuffixDirective.

Other information

@xelaint xelaint added the package: design @daffodil/design label Dec 30, 2024
@xelaint xelaint requested a review from a team as a code owner December 30, 2024 15:02
@xelaint xelaint force-pushed the prefix-suffix-standalone branch from 51f65dc to 1d1eb25 Compare December 30, 2024 15:07
@xelaint xelaint added the status: awaiting review This PR is awaiting review label Jan 8, 2025
@xelaint xelaint requested a review from damienwebdev January 8, 2025 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: design @daffodil/design status: awaiting review This PR is awaiting review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant