-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(daffio): render design component guide and API docs with tabs #3377
base: develop
Are you sure you want to change the base?
feat(daffio): render design component guide and API docs with tabs #3377
Conversation
@xelaint lmk what you think about the implementation and I'll fix the tests if there are no changes that need to be made |
|
apps/daffio/src/app/docs/components/doc-viewer/doc-viewer.component.html
Outdated
Show resolved
Hide resolved
5a7e48e
to
7e3cf9f
Compare
39cfb87
to
7e3cf9f
Compare
@griest024 Clicking on |
Yeah toc is broken with tabs. It's something that needs to be fixed in dgeni/daffio though, it's not a problem with the tabs component |
API headings don't have |
yes |
7e3cf9f
to
b1a4b02
Compare
@xelaint ready for re-review |
Do you specifically want them to not be links? I thought it would be handy for them to be links |
They link to a separate api page, but this view is already the api tab view. Don't think that makes sense since we got rid of a separate api page for design? |
I see what you're saying but I thought the API tab would display a trimmed down version of the API and then the API page would have everything includes examples and source block, etc. I'll remove the links if you don't want them; I don't have a strong preference for them. |
No, the API tab should display everything, except examples. There's not need for separate pages. So pages like |
@xelaint I've made all your requested changes |
apps/daffio/src/app/docs/design/components/component-content/component-content.component.html
Outdated
Show resolved
Hide resolved
apps/daffio/src/app/docs/design/components/component-content/component-content.component.html
Outdated
Show resolved
Hide resolved
Co-authored-by: Elain T. <[email protected]>
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Fixes: #3366
What is the new behavior?
Does this PR introduce a breaking change?
Other information
@example
#3392