Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rendering for landuse=greenhouse_horticulture #82

Closed
wants to merge 1 commit into from

Conversation

mfornasa
Copy link

Fixes #78

@matthijsmelissen
Copy link
Collaborator

@matthijsmelissen
Copy link
Collaborator

This tag gas 18 613 occurrences. As far as I'm concerned, it can be merged.

@matthijsmelissen matthijsmelissen changed the title Rendering of landuse=greenhouse_horticulture Add rendering for landuse=greenhouse_horticulture Sep 24, 2014
@matthijsmelissen matthijsmelissen modified the milestones: 3.x - Needs upgrade to mapnik or openstreetmap-carto.style, Bugs and improvements, New features Sep 26, 2014
@matkoniecz
Copy link
Contributor

I strongly dislike the tag itself, I think that such areas should be tagged as landuse=farmland, farmland=greenhouse_horticulture.

But at least such areas should be rendered exactly like farmland - yet another landuse colour is not a good idea.

@dieterdreist
Copy link

2014-10-10 17:49 GMT+02:00 Mateusz Konieczny [email protected]:

But at least such areas should be rendered exactly like farmland

-1, they are so different that they merit their own rendering style IMHO.
Please have a look:

http://lh4.ggpht.com/-GVwdFatY5W4/UiGe2oPoHZI/AAAAAAAAr60/MBzKZdxoVLE/greenhouses-almeria-3%25255B2%25255D.jpg?imgmax=800
http://lh3.ggpht.com/-ZTtqzs1TqOg/UiGezzFi-2I/AAAAAAAAr6s/8EXbbnX-EaQ/greenhouses-almeria-10%25255B5%25255D.jpg?imgmax=800
http://www.rufepa.com/img/inv_plastico/inv_parral24_z.jpg

visually they are more similar to built-up space than they are to farmland.

In areas with fewer of them they can serve for orientation purposes.

@mfornasa
Copy link
Author

I also think that this can be really useful for orientation purposes. Greenhouses are, in fact, buildings, as opposed to farmland, which is usually without buildings.

@matkoniecz
Copy link
Contributor

Greenhouses are, in fact, buildings

Yes, so greenhouses will be tagged and rendered as buildings. Is it reall necessary to make a separate colour for landuse?

@matkoniecz
Copy link
Contributor

@dieterdreist

-1, they are so different that they merit their own rendering style IMHO

I am not convinced. For example patches of small fields, rice terraces, giant corn fields, cauliflower fields, fields of sunflowers, intensively irrigated fields on desert and cotton fields are also really different. Is it a good idea to have a separate rendering for all kinds of farmland?

@dieterdreist
Copy link

2014-12-11 17:25 GMT+01:00 Mateusz Konieczny [email protected]:

-1, they are so different that they merit their own rendering style IMHO

I am not convinced. For example patches of small fields, rice terraces,
giant corn fields, cauliflower fields, fields of sunflowers, intensively
irrigated fields on desert and cotton fields are also really different. Is
it a good idea to have a separate rendering for all kinds of farmland?

yes, I think it might merit consideration to have different rendering
styles e.g. for fields "under water" and those that are dry. I am not
advocating a completely differentiated farmland map for the main style, but
we are already distinguishing vineyards for instance.

@matkoniecz
Copy link
Contributor

vineyards

also - orchards.

matthijsmelissen added a commit to matthijsmelissen/openstreetmap-carto that referenced this pull request Mar 21, 2015
@matthijsmelissen
Copy link
Collaborator

Superseded by #1435.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement landcover new features Requests to render new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add rendering for landuse=greenhouse_horticulture
4 participants