Render leisure=dance

[wyskoj]

Changes proposed in this pull request:

Add rendering for leisure=dance

lesiure=dance is used 11k times across a wide geographic area, and it has been approved since 2009.

Icon

I designed a simple icon.

I did my best to follow as many icon style guidelines as possible, most notably aligning to a 14x14 pixel grid:

Test rendering

Location 1

On a way with building=*.

Before

No rendering (name is rendered with building).

After

z19

z18

z17

<=z16

No render, consistent with other leisure and amenity features.

Location 2

On a node.

Before

No rendering.

After

z19

z18

Text occluded by other features.

z17

Icon happens to have precedent here.

<=z16

No render, consistent with other leisure and amenity features.

Notes

• Style is grouped in with leisure=sauna for ease of implementation. I don't have a strong preference for this feature's color, but I think it makes sense since most other leisure features use this color.

Thanks for considering my PR!

[imagico]

Thanks for the pull request.

I think the tag is suitable for rendering, no competing tag with comparable adoption, geographically broad use by individual mappers in different parts of the world, well established over several years.

The symbol design principle seems suitable as well - dancing human figure and music notes to avoid confusion with sports.

I am a bit wary about the readability of the symbol because of the elements being very small. One thing that might help is avoiding the bottom diagonal line formed by the feet of the figure and the music notes - which could be misread as the two symbols components forming a geometric unit. Maybe you could try re-arranging - mirroring/swapping the two elements in some form that disrupts this line.

Side note: I generally dislike the use of green for social amenity symbols because IMO green should be reserved for vegetation related features. But that is not a matter significant for this PR, it is a more general comment.

[dch0ph]

Nice job!

I agree that the symbol works - figure + note unlikely to be confused with a sport symbol. The musical notes are quite small and not instantly recognizable. You could try using a mitre join for the top bar (rather than rounded corners). A thicker top bar (1.5 px), as in conventional musical notation, might also help?

[wyskoj]

Maybe you could try re-arranging - mirroring/swapping the two elements in some form that disrupts this line.

You could try using a mitre join for the top bar (rather than rounded corners). A thicker top bar (1.5 px), as in conventional musical notation, might also help?

I've enacted both of these suggestions, and I think they improve readability.

I generally dislike the use of green for social amenity symbols because IMO green should be reserved for vegetation related features.

I'm happy to set a different color if there's one you prefer—should be a simple fix.

[imagico]

Merging this to be included in the next release, sorry for the long wait time. The use of green color for not vegetation related symbols is a different and more general issue, which will need to be discussed separately.

Nice work on the design.