Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore reef name rendering #4918

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Conversation

dch0ph
Copy link
Contributor

@dch0ph dch0ph commented Dec 24, 2023

Fixes #4898

Changes proposed in this pull request:

Restore rendering of reef name removed in #3712. mss code still present, just fixing SQL query.

Test rendering with links to the example places:

Black Middens at Z16

Before

image

After

image

(Modified render chain hence different typeface, but otherwise identical to standard tile server)

Copy link
Collaborator

@imagico imagico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works as intended:

z16z17

For clarification: This is meant to restore previous consensus styling which was unintentionally changed in #3712. As explained in #4898 (comment) the question if or not to render name labels for natural=reef should be newly evaluated IMO for the reasons pointed out there. But we should do so starting with the previous consensus state, not the unintentional styling we have right now.

And also to be clear: This is not an endorsement of the use of natural=reef shown in the example - which is a non-consensus use of the tag for a tidal area.

@imagico imagico merged commit 50e7457 into gravitystorm:master Jan 8, 2024
2 checks passed
@dch0ph dch0ph deleted the restore-reef-name branch January 10, 2024 21:13
@imagico imagico mentioned this pull request Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Render names on natural=reef
2 participants