Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rendering of highway=track that was broken in PR #4666 #4895

Merged

Conversation

MeonStudios
Copy link
Contributor

@MeonStudios MeonStudios commented Nov 2, 2023

Fixes #4881

This PR has no new features but a bugfix:

  • highway=track is fixed and again rendered like it is in the current release
  • roller_coaster=track has no visual changes

Examples

Before

highway=track is rendered like it is a roller coast track
image

After

highway=track is rendered correctly again
image

Before

roller_coaster=track is rendered
image

After

roller_coaster=track is still rendered the same way, no visual changes
image

@pnorman pnorman self-requested a review November 2, 2023 18:37
@pnorman
Copy link
Collaborator

pnorman commented Nov 2, 2023

cc @tjur0, if you could also review it.

Copy link
Contributor

@tjur0 tjur0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
image_2023-11-05_14-56-44

@MeonStudios
Copy link
Contributor Author

Anything needed from my side before we can merge this?

Copy link
Collaborator

@imagico imagico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works as expected. Thanks.

@imagico imagico merged commit 73ea404 into gravitystorm:master Nov 9, 2023
2 checks passed
@MeonStudios
Copy link
Contributor Author

Great thanks for taking the time to check! Are there any other blocking issues for a (potential) release? Then I know what I will pick up next.

@imagico
Copy link
Collaborator

imagico commented Nov 10, 2023

I opened #4900 to discuss the next release. There is nothing really blocking it. I also created #4901 aiming to list the most important issues of the style currently and what state they are in. Note, however, that these are not really recommendations what to work on as a developer, they are more strategic issues where working on a consensus direction is required.

Generally speaking work on bug fixes and improvements of existing features is more important that feature additions. In particular desirable IMO are feature removals - though these also tend to attract loud opposition - which can be unpleasant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression in highway=track rendering due to color re-definition in #4666
4 participants