-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Borders for archeological site polygons. #3959
Conversation
Sounds like really a kind of tourism attraction site. Almost half of them is mapped as an area/relation (27 088+943), so it makes sense to show the shape of the place. |
OTOH it will highlight places like https://www.openstreetmap.org/way/476382208 which look more like actual archeological excavations than tourist attractions. |
4.52% of all the historic=archaeological_site has a tag of tourism=attraction, this sounds to me like reasonable combination to make it different from typical excavation area. |
I am fairly inclined to be against this - for a number of reasons:
|
Let's add |
If you mean the last picture near Lago di Bolsena, that is Parco Naturalistico Archeologico Vulci, and I don't think it is a bad tag. According to this site: https://www.italiaparchi.it/parchi-di-arte-e-storia/parco-naturalistico-archeologico-di-vulci.aspx the park itself is at least 9 km2, and encompasses one of the largest Etruscan cities - Vulci - and multiple necropoles with some 30.000 tombs. The city was destroyed by the Romans in 280 BC according to this website (and seems to have been rebuild as Roman): https://vulciturismo.com/il-parco/ There also seem to be multiple opportunities for hiking, horse riding etc in the park. |
I wanted to also display the name and maybe an icon, and I found that we're already doing it, but in the |
To reinforce that, there are archaeologic sites that are the exact opposite. I remember archaeologic probing along a planned motorway, and in one spot relevant objects were found. It created some local news about this heritage, the motorway was changed to bypass the spot. The site is listed as archaeologic, and mapped in OSM as such. Public access is forbidden, thus not touristic at all. |
BTW, what is that big bright-red flower icon in the first post's examples? |
My cursor, the screenshot app is including it :( |
I don't think it makes sense to only render the combination of In the past, this style used to render "Rendering of tourism=attraction areas is not really useful, as it may be exactly anything and anyway this pink area rarely gets displayed." Then in issue #1257 there was a request to "Add area render for tourism=attraction" and this was rejected with these comments #1257 (comment) and #1257 (comment) There was also #1824 (comment) which declined rendering tourism=attraction lines. More recently - in PR #3603 - we stopped rendering the |
I believe a large part, perhaps the majority, of historic=archaeological_site features may be closer to these. If we look at the key site_type, 37,000 features are a The next most common are "fortification" (stone walls and earth walls), "megalith" and "settlement". Most of these are not at all similar to a theme park or zoo-like feature. The historic European city centres, with their world-famous historic sites, are the exception. Because historic=archaeological_site does not appear to be similar to theme parks and zoos in function for most general map users, it would be better to render it differently. A more reasonable comparison might be museums or other cultural features. Currently there is no polygon fill rendering for There was also some discussion about using |
I did this to not render sites that are not open to the public. There is not much combination with access tags. Maybe I shouldn't worry about this at all. |
@StyXman would you be interested in trying a rendering with |
This would need to rebased for v5.0.0 - @StyXman, are you considering working on this further? |
I wish I had the time and energy. Family life has been intense this winter. I have no ETAs. |
Closing as stale. If anyone is interested in rendering these features and other cultural amenitys with |
Fixes #3958
Changes proposed in this pull request:
historic=archeological_site
to#tourism-boundary
.Test rendering with links to the example places:
Athena: https://www.openstreetmap.org/#map=15/37.9742/23.7297
Italy: https://www.openstreetmap.org/#map=11/42.4126/11.9428
Roma: https://www.openstreetmap.org/#map=16/41.8915/12.4839
Messini: https://www.openstreetmap.org/#map=14/37.1780/21.9276
Olympía: https://www.openstreetmap.org/#map=13/37.6417/21.6304
After:
Athena:
Italy:
Roma:
Messini:
Olympía:
Roma becomes a little bit more busy, but that's because every ruin has been mapped independently instead of mapping the whole Forum. I would like also to see how Petra (16/30.3280/35.4458) renders, but I don't have it in my import.
Finally, I should also include names in labels.