-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nature reserve boundaries revision #3574
Conversation
@vholten Can you try with 1.3 width on z8 and 1.6 on z9? When I was checking test images on my mobile phone, these borders were quite hard to see. |
Thanks! Please test also this place where these areas are not only an outiline over bare ground |
Thanks for doing this @vholten. It looks a lot better. |
I think they are a little bit too thick on z10 also (e.g. https://www.openstreetmap.org//#map=10/51.4326/13.3690), so I propose a scale with:
|
@Tomasz-W Can you give some test rendering for this proposed scale? |
@matkoniecz I plan to show test renderings for this PR and for the scale proposed by @Tomasz-W in the area of https://www.openstreetmap.org/#map=8/48.897/20.599 within the next couple of days. |
I have done some tests in the region suggested by @Tomasz-W and based on the results I think that the borders should be made a bit stronger than in my first proposal on z8 and z9 (opacity of 0.25 instead of 0.2). (All test renders also use #3553 and #3563.) z8z8 first proposal (opacity 0.2): z8 proposed stronger borders (opacity 0.25): z9z9 first proposal (opacity 0.2): z9 proposed stronger borders (opacity 0.25): z10 |
When you update the code I guess it will be ready to merge. |
I've updated the code with the proposed changes. These are:
I've also updated the test renderings of Northern California in the first post. What do people think about making borders thinner on z11 as well? |
It's hard to say, please show some test rendering. |
z11 current PR (https://www.openstreetmap.org/#map=11/49.5525/20.1495): |
Works for me. |
I've updated the code, I guess it's ready to be merged. |
Thanks! Further tuning is still possible, but this helps a bit anyway at the moment. |
Related to #3538, #2978
Changes proposed in this pull request:
Test renderings of Northern California
z8 before:
z8 after:
z9 before:
z9 after:
z10 before:
z10 after: