Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix private parking icons at wrong zoom i312 #316

Closed
wants to merge 1 commit into from

Conversation

Rovastar
Copy link
Contributor

#312
I am pretty sure that is right but cannot test atm.

gravitystorm#312
I am pretty sure that is right but cannot test atm.
@mrwojo
Copy link
Contributor

mrwojo commented Feb 7, 2014

There should be commas between the [access = *] checks. The private P symbols should be in a separate attachment with lower priority, otherwise a private P could still block a public P. Also, eventually we'll have to properly check for nulls ([access = null]).

The SQL query could differentiate the access types to handle this more cleanly in Carto if such checks become more popular (as suggested in #323). When access is null or ('', 'yes', 'public'), then access is 'INT-yes'. The styles would be more straightforward, like:

  [amenity = 'parking'][access = 'INT-yes'][zoom >= 15]::amenity {
    point-file: url('symbols/parking.p.16.png');
    point-placement: interior;
  }

  [amenity = 'parking'][access != 'INT-yes'][zoom >= 16]::amenity_private {
    point-file: url('symbols/parking_private.p.16.png');
    point-placement: interior;
  }

@gravitystorm
Copy link
Owner

Closed - as per mrwojo's comments in the first paragraph

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants