-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rendering power=plant outline #2839
Conversation
Any other such objects with invisible areas which should be visible? |
plant was the first and only object i remember which should be inside industrial area. |
I'm not sure what this outline accomplishes. |
It shows the area without the landuse, indicating that it should be added. |
What does it look like on an industrial landuse background? Also in that case it might be nice to have the outline of the actual plant. |
It's the same code as in #2700, so look at #2700 (comment).
What do you mean? |
If we have power=plant within landuse=industrial, it would be good if the power=plant outline is still visible, but I believe your PR accomplishes that. I would also be fine (and maybe even prefer) with giving power=plant a purple background like landuse=industrial. |
What would be the reason for rendering (or not rendering) purple background? I don't have an opinion now. |
If the purpose is to reveal this as an error, that's something for a debugging layer, not a general purpose layer. If we want to render power plants like industrial areas we could do that. |
Well, for the man_made=works it was to show both - that's incomplete tagging and showing that it's not a node, but a bigger object. It all depends on how we see the problem of area objects and landuse - if I understand correctly (I'm not sure if I really do):
So:
|
As to fill for power=plant, be aware that there are also dispersed power plants, tagged as one entity. E.g. groups of windmills at sea, or solar panels, may be tagged with one closed way and power=plant. See the wiki also: A fill is not appropriate in this case, only outline rendering makes sense. |
Actually, he wrote he doesn't like to have the label styled based on way_area if there is nothing that shows the extent of the area. It's a subtle difference, but it does make sense. |
I will put this information also here: If nobody help me fix this code to the acceptable form, I plan to close it without merging in a few days. |
Follow up to #2700.
Umspannwerk Dieringhausen, z19
Before
After