Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make regional admin borders solid instead of dashed #2834

Merged
merged 1 commit into from
Sep 17, 2017

Conversation

matthijsmelissen
Copy link
Collaborator

@matthijsmelissen matthijsmelissen commented Sep 14, 2017

Due to the coastline paradox, dashed lines for borders don't work
well on low-zoom: strongly curved borders appear solid instead of
dashed. Also, solid dashes generally are too busy for the crowded
z5-7.

This PR makes regional boundaries (admin_level=4) solid instead of
dashed up to z9.

To prevent the borders from getting too strong, they are also made
thinner.

Before/after:

z4:
screen shot 2017-09-14 at 23 40 26 screen shot 2017-09-14 at 23 40 03

z5:
screen shot 2017-09-14 at 23 40 57 screen shot 2017-09-14 at 23 41 18

z6:
screen shot 2017-09-14 at 23 41 41 screen shot 2017-09-14 at 23 41 31

z7:
screen shot 2017-09-14 at 23 42 19 screen shot 2017-09-14 at 23 42 10

z8:
screen shot 2017-09-14 at 23 42 46 screen shot 2017-09-14 at 23 42 39

z9:
screen shot 2017-09-14 at 23 43 00 screen shot 2017-09-14 at 23 42 54

@kocio-pl
Copy link
Collaborator

Thanks, it's a really useful change!

Maybe this makes it more solid and violet+red is a bit more dominating on low zoom (see #1935), but low zoom changes are still ahead of us (#2688) and we can try with borders color change (like #2695) and at least it stops looking like artefacts (another kind of high frequency noise to remove - see also #2199):

Poland, z6
Before
uaz5sd2i
After
bsinrnem

On the other hand I'm not sure to which zoom level it should be used. You were testing in Africa, but in Europe we have more linear entities (like roads, railways and rivers), so maybe z7-z9 should be left untouched to be more distinct.

Poland, z9
Before
tlgbt2u4
After
vs0hmqph

Copy link
Collaborator

@kocio-pl kocio-pl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great change for z<7, but z7+ should be left a it is to be more distinct from other linear features.

Copy link
Collaborator

@pnorman pnorman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good, but I haven't run them, and would want to look at higher zooms locally.

Due to the coastline paradox, dashed lines for borders don't work
well on low-zoom: strongly curved borders appear solid instead of
dashed. Also, solid dashes generally are too busy for the crowded
z5-7.

This PR makes regional boundaries (admin_level=4) solid instead of
dashed up to z6.

To prevent the borders from getting too strong, they are also made
thinner.
@matthijsmelissen matthijsmelissen force-pushed the admin-dashes branch 2 times, most recently from c89b9c1 to 8b3382c Compare September 17, 2017 00:05
@matthijsmelissen matthijsmelissen merged commit 8b3382c into gravitystorm:master Sep 17, 2017
@matthijsmelissen
Copy link
Collaborator Author

I agree with @kocio-pl. I restricted the PR to zoom level 4-6. Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants