-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding icon for amenity=university and amenity=college [WIP] #2361
Conversation
PLEASE not. Having a scaling name for these is one of the best thing about them, and anything with an icon has a name that can't scale anymore according (IIRC) pixel_area. In fact, I personally wish we could reasonably get rid of the hospital icon so hospital names could scale too. |
That's not a technical limitation, so if we want scaling labels in combination with icons we can define rules that allow this. Currently, caravan sites already do have a scaling label in combination with an icon. See also #1355. @Circeus, I would be very interested in hearing your feedback on that issue. |
sent from a phone
but it's a limitation designwise, either we scale the icon along with the text (would be a big change) or it will lead to strange looks (tiny icon compared to text). |
Do you need an icon for a university given that the name will usually include "university" in it? |
Not saying we would, but we could show the university icon on lower zoom levels, before the name can be displayed, to indicate the campus location inside the city. |
No evidence just my hunch for the UK. Just seems like there was a lot of On 13 Oct 2016 9:04 a.m., "Matthijs Melissen" [email protected]
|
Can we reach some agreement with this PR? If not, I'm gonna close this PR without merging in a few days. |
In favour of merging. |
I don't like this change. Icons suggest nodes or small areas. We could enable this icon for nodes only but enabling it also for areas makes the campuses look worse IMHO. |
That would be inconsistent with how we deal with hospitals. Do you think that universities are different in that regard? |
What about first trying to render the name (in italics), and if it doesn't fit render the icon (without label)? |
hm is that consistent behaviour someone would expect? Would that mean that in lower zoom I see an icon, when I zoom in the name?
First time I hear about such rule.
Why? Maybe you have a campus that is tagged incorrectly, i.e. amenity nodes/buildings within the campus amenity? Nodes and areas should not be treated differently in rendering, often a node is a first step in mapping before it is expanded to an area. |
@kocio-pl I don't think hospitals are any different - they should be handled the same way, true. @polarbearing I don't know any rule, that's just my subjective opinion. I'm not quite convinced to it, but I would prefer it to the current proposal. |
I think we should first rethink how do we render similar objects and then go back to this problem. Thanks for the feedback! |
Further discussion in #3284 |
Related to #120 (partial solution).
Code based on amenity=hospital, but using current university/college label color.
Area, z15
Before
After
Area, z16
Before
After
Area, z17
Before
After
Node, z16
Before
After
Node, z17
Before
After
Node, z18
Before
After