Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show national park boundaries from higher zoomlevel and larger size #2119

Merged
merged 1 commit into from
Dec 9, 2017

Conversation

matthijsmelissen
Copy link
Collaborator

With this commit, national park boundaries will be shown from the
same zoomlevel and size as their label, effectively eradicating
small unlabelled national parks from the rendering.

Such small national parks seem to contribute to a crowded feel of
the map in the areas and zoom levels where they occur.

@pnorman
Copy link
Collaborator

pnorman commented May 14, 2016

I prefer showing the parks too small to fit a label in

2119_new1
2119_master

@imagico
Copy link
Collaborator

imagico commented May 14, 2016

IMO neither of these looks good, displaying national parks at this scale in this way seems to be causing more harm than have advantages.

In the US a lot could be gained by dissolving the inner boundaries and essentially showing the protected area as a whole - still keeping the labels but without indications where one park ends and another starts - which is confusion at this scale anyway.

But this would not solve all of the problems related, especially the color distortions of other elements through the semitransparent fill and border and the color confusion with natural=wood.

@pnorman
Copy link
Collaborator

pnorman commented May 14, 2016

I think completely changing the national park rendering is outside the scope of this PR

@matkoniecz
Copy link
Contributor

I prefer showing the parks too small to fit a label in

I also share this opinion, I think that this change makes situation pretty confusing.

@matkoniecz matkoniecz closed this Jun 6, 2016
@matthijsmelissen matthijsmelissen deleted the national-park-zoom branch August 5, 2016 08:35
@matthijsmelissen matthijsmelissen restored the national-park-zoom branch October 24, 2017 20:30
@matthijsmelissen
Copy link
Collaborator Author

I am re-opening this PR. I think the amount of small nature reserves is still a big problem. The number of places where rendering them looks good is greatly outnumbered by the number of places where they cause a problem.

screen shot 2017-12-07 at 00 39 11

screen shot 2017-12-07 at 00 38 28

screen shot 2017-12-07 at 00 37 37

@matthijsmelissen
Copy link
Collaborator Author

matthijsmelissen commented Dec 6, 2017

Rebased.

Note that the change in zoomlevel has been merged before.

With this commit, national park boundaries will be shown from the
same zoomlevel and size as their label, effectively eradicating
small unlabelled national parks from the rendering.

Such small national parks seem to contribute to a crowded feel of
the map in the areas and zoom levels where they occur.
@matthijsmelissen
Copy link
Collaborator Author

Can anybody review this (again)?

@matthijsmelissen matthijsmelissen mentioned this pull request Dec 9, 2017
@kocio-pl
Copy link
Collaborator

kocio-pl commented Dec 9, 2017

I think it is useful to start with that. I want to add boundary=protected_area later and use different zoom levels too (see #603), but that can take me some time.

Example (click to see the full size):

z8
Before
brtumbl6
After
p9lqeuvn

z9
Before
spyzctoa
After
m7e5qehp

@kocio-pl kocio-pl merged commit 57e7c80 into gravitystorm:master Dec 9, 2017
@kocio-pl
Copy link
Collaborator

kocio-pl commented Dec 9, 2017

Another example - near Warsaw:
Before
aq2tiysm
After
go7j1nzi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants