Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helper script to get list of most frequent values for a key from taginfo #192

Closed
wants to merge 1 commit into from

Conversation

vincentdephily
Copy link

The idea is that this script would help to define the values that need to be rendered,
finding the most frequent ones and avoiding explicit negatives and misspellings.
This commit just adds the script, but doesn't make actual use of it anywhere yet.

The idea follows discussions on #116 and #182.

@gravitystorm : when I said that 'rendering "all" values of a tag is often desirable', the quotes were important : We clearly do not want to render misspelings and "no" values. So we use a whitelist and avoid catch-alls.

But for some keys like 'shop' or 'tunnel', that whitelist can become large and unwieldy. This script just makes the creation and maintenance of those whitelists easyer, based on the observations that cutting off the long tail and some frequent-but-unwanted values makes a pretty nice list.

Of course, the script's output must be reviewed. But eventually, instead of storing the actual output, we could just store the parameters (key, threshold, blacklist). That's to be done on a case by case basis.

…aginfo

The idea is that this script would help to define the values that need to be rendered,
finding the most frequent ones and avoiding explicit negatives and misspellings.
This commit just adds the script, but doesn't make actual use of it anywhere yet.
@gravitystorm
Copy link
Owner

I think this is a useful script, but I'd prefer to see it developed independently (and therefore stored in an independent repo) from these stylesheets. It'll be useful to other people for other stylesheets too, and I prefer to keep projects separated.

@vincentdephily
Copy link
Author

Thanks for the review.

Keeping the script in the style's repo makes sense if we also store the script's parameters in the repo, but I understand that we don't want to do that yet.

Puting the script in some other "bag of tricks" repo would be good too, but I have no idea of which repo would fit that description ? A repo for a lone script seems silly.

@gravitystorm
Copy link
Owner

I wouldn't worry too much - most single scripts generally evolve into bigger things as time goes on!

I don't have any suggestions for existing repos where it might be at home - perhaps you could ask on the [email protected] mailing list for suggestions.

@pnorman
Copy link
Collaborator

pnorman commented Nov 17, 2013

you could use osmlab. I can set up a repo there if you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants