-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bridge=Yes does not render unless associated with rendered highways/railways #612
Comments
2014-06-09 13:41 GMT+02:00 Rovastar [email protected]:
because "bridge" is an attribute, it is not defining a bridge by itself, |
Do we have a way to tag wild passages (not sure how they are called in English)? |
enwiki has it as "wildlife crossing" http://en.wikipedia.org/wiki/Wildlife_crossing |
I understand why but if there is a bridge should we render it? Probably yes, as it is an actual thing. |
IMHO disused but existing bridges and bridges with otherwise unrendered objects should appear (for example pipelines, wildlife crossings etc). |
Nice collection of examples: http://nl.wikipedia.org/wiki/Grote_nutteloze_werken |
So how do we tag things like this? http://upload.wikimedia.org/wikipedia/commons/thumb/9/91/ViaducInutile.jpg/1024px-ViaducInutile.jpg |
bridge=yes, highway=trunk(?), access=no, oneway=yes |
Wildlife crossing is wood over a tunnel for me. |
Also related to #436. |
Not sure if this is a good idea, but man_made=bridge could potentially be used as a physical thing that we can render ? I'm just afraid that it could lead to cargo-culting and tagging for the rendered. It also feels weird that mad_made=bridge would be needed for some objects but not others. On the other hand, I'm not sure I agree with the "bridge=yes is just an atribute" claim. It seems rather pedantic and, even ignoring the issue of a bridge supporting something that we don't render, there is the case where a surveyor or amrchair mapper will see the obvious bridge but have no clue as to what it supports (if anything) and decide to only tag bridge=yes until he knows better. |
an explicit bridge object would also solve the longstanding problem of distinguishing several parallel bridges from one bridge with several carriageways (confirms the attribute point of view) |
Yes, that's what man_made=bridge and the corresponding relation are for. Go use them :) BTW, it would be great to get osm-carto to render it. But you can't expect this tagging scheme to be used everywhere. Especially in the cases that osm-carto currently doesn't render, mappers are likely to use the simpler bridge=yes tagging scheme. Looking at the wiki, the wording never implies that bridge=yes is an attribute of the object rather than the object itself. Tagging bridge=yes on its own is a reasonable thing to do. Maybe we need to change the rendering of briges yet again to be drawn around the ways rather than on the way's casing. That'd make the rendering consistent with multi-way bridges, and might make standalone bridges easyer to reason about. |
Vincent, what do you mean with
The bridge relation? |
There is a special kind of wildlife crossing bridge here: http://www.openstreetmap.org/way/199456384 and here: http://www.openstreetmap.org/way/198641856 I would say, let's render man_made=bridge and the bridge relation (#436). If it's an area, fill it with a grey colour. And if it's on a way, draw it similar to a bridge now. |
2014-06-13 12:17 GMT+02:00 vincentdephily [email protected]:
I think this is pretty clear from the actual mapping: you add it to the |
2014-06-13 16:33 GMT+02:00 daganzdaanda [email protected]:
+1 |
@RussNelson - can you link some mapped bridges with railway=abandoned? I plan on making pull request that would restore rendering of [railway=abandoned, bridge=!no]. https://www.openstreetmap.org/way/208510269 was already linked in #542 http://www.openstreetmap.org/way/4929040 is linked below |
http://www.openstreetmap.org/#map=16/52.4760/-1.8793 What do we do with abandoned railway tunnels that are now cycling paths? I.e. http://www.panoramio.com/photo/76193510. Note that the default is that railways render on top of roads. |
This one would be IMHO [highway=cycleway, tunnel=yes, lit=yes, surface=asphalt]. There is no trace of railway here (maybe in the name?), so there is no place for railway tag (note: I based this on the single photo, maybe there is reason for more tags). |
I think @RussNelson would disagree. This is a typical example of an abandoned railway that is still visible in the landscape (the tunnel used to be a railway tunnel only). What about this one? http://www.omroepbrabant.nl/Graphics/Image.aspx?object=News&type=large&image=De_man_sloeg_de_hand_aan_zichzelf_aan_het_Halve_Zolenpad_1114133.jpg |
I'm having a bit of trouble finding them in OpenStreetMap because they're not rendered anymore. But I think I remember where a few are. I'll get back to you. |
Here's the URLs to the four pictures I posted, in order: |
What should a bridge look like if the base feature isn't being rendered? |
I am unsure whatever even railway tags are appropriate. Mapping tunnel, embankments, change of landcover etc certainly should be mapped - but "X used to be here" seems dubious, what about logical extending this and mapping buildings that no longer exists? Both images provided by @math1985 IMHO depicts something that used to be railway infrastructure but it no longer is one. IMHO any tags that are used to describe railwayness of these structures should be ignored in rendering (and that is the current approach). On the other hand images provided by @RussNelson in #612 (comment) depict infrastructure that IMHO should be rendered and currently is not (only second would be currently rendered as road tunnel).
Just bridge casings without anything inside? It can also make pipeline bridges visible (small part of #640), though I wonder whatever rendering man_made=bridge would be preferable (#436). |
Well (of course) the base feature, in this case abandoned railways, SHOULD be rendered. The trouble is that most mappers, myself included, never anticipated the day when abandoned railways would be treated the same as dismantled railways (even though they aren't dismantled), and so weren't careful about tagging dismantled railways. Since railway=abandoned is now a mix of (the real) railway=abandoned and railway=dismantled, and some people don't want to see railway=dismantled running through their mall or housing development (reasonable) they have resorted to not rendering railway=abandoned (unreasonable). But, really, that's a separate problem. Just render the bridge as if it still exists (which it does) for its most recently used purpose (which it still could be). There are over 300 railway=abandoned bridge=yes in New York State and as of a month or so ago, all of them disappeared from OSM. That's a shame. |
This issue is about of bridges should be rendered where the base feature is not, not if abandoned railways should be. If you want to discuss that, there is probably an issue covering that, or create a new one if not. |
Because that's not logical. If a building no longer exists, there is no evidence that it was ever there and should not be rendered. If a railway no longer exists, there is almost always evidence that it was there, if only because the railway you can see has a gap in it. E.g. in the case of the bridge to the east of the tunnel (the third URL I posted above), it has rails to the east and west of it (in the tunnel), but no rails on it. |
what about tagging man_made=bridge or building=bridge? (and rendering it) |
Further example that just tripped me up: this big-assed bridge is now not rendering due to having a railway=abandoned on top. OSM object: http://www.openstreetmap.org/way/70125797 |
2014-09-01 12:17 GMT+02:00 Richard Fairhurst [email protected]:
we should really start mapping bridges generally, without relying on ways |
Another UK example: https://www.openstreetmap.org/way/37548602 - while people do walk along the top of this, I don't think there's a legal right of way. |
Does osm-carto code contributors plan to deploy this rendering? Taginfo says we have now 2 341 965 objects tagged "bridge=yes" (even the second kv pair, "bridge=viaduct", is notable - 41 583 objects), so the evidence that this feature is important is strong: |
2015-02-11 14:36 GMT+01:00 kocio-pl [email protected]:
if you read the contributions in this issue you'll find that "bridge=yes" |
Sure - I just realized it later... =} It means we don't have clear numbers, but still some of the bridges have multiple highways on it (those are probably important by definition and I guess not all of them have the outline tagged) and even those with just one lane can be better shown at maximum zoom level when rendered with the outline. |
I think this issue should be closed, since it's misleading. |
@daganzdaanda No, this issue is for bridges without rendered ways, not bridges without ways of any sort. For example, this modest structure: http://weirdnj.com/stories/paulinskill-viaduct/ |
OK, thanks, I got confused! |
We're not rendering the Paulinskill Viaduct? It dominates the landscape in Hainsburg. There is no place in town where you can't see it .... except if you're looking at OpenStreetMap. I'm sympathetic to the idea that if you can't see it, it shouldn't be rendered. Can I get a little sympathy for the idea that if you CAN see it, it SHOULD be rendered? I'm also sympathetic to the idea that rendering every railway=abandoned is wrong, because there are places where even I cannot see that a railway used to go. So how about this suggestion: we render railway=railbed, for those places where an ordinary mapper can see a railbed, whether on aerials or on site. That way, those of us who can see the Paulinskill Viaduct can tag it as railway=railbed, and we can close this issue once and for all. |
2015-02-17 10:57 GMT+01:00 kocio-pl [email protected]:
yes, I am absolutely in favor of tagging/mapping bridges as their own |
https://www.openstreetmap.org/way/95507414 I'll change the railway on the bridge to "railway=railbed" since I think this is a good tag and I don't believe that there is really a current proposal for a new rail on that route. I'll not touch the rest of the railway at the moment, since I don't know where exactly "abandoned" or "railbed" would be best. |
What - we're now proposing tagging changes from OSM carto github issues now? http://taginfo.openstreetmap.org/search?q=railway%3Drailbed (currently 0 uses) Well, I suppose it makes a change from telling the style developers how to render stuff from Every Other OSM List :) |
Oops ;-) |
Yes, I did propose it, and while it seems perfectly sensible, and a solution to everyone's objections in every regard, I got no positive responses. Do I need to make this suggestion in the form of a pull request? Yes, nobody is using railway=railbed now. That's the whole point -- people don't want railway=abandoned to be rendered because it is probably 30-40% MISUSED. Yet rendering encourages mapping, so if railway=railbed starts getting rendered, then people will be rewarded for fixing all the wrong railway=abandoned's. |
Please remember what the issue is about. It is about ways with bridge tags with no other tags that are rendered, it is not specific to railways. This issue would not change if there were changes to what railway tags were rendered. If you believe there are new tags that should be rendered create a new issue for them, do not discuss them here. |
Please remember that this problem was created by ceasing the rendering of abandoned railroads. If we can fix that problem, this problem will be fixed at the same time. If you believe there are new tags that should be rendered which will solve this problem, please discuss them here. |
Locking until @gravitystorm gets back. This issue has gone entirely off-topic, and no discussion is being done on how a bridge should look if its underlying feature is not rendered. |
This issue is closed since it has been driven far off topic. |
A bridge by itself does not render in needs a rendered way for it to appear.
Related to #542
The text was updated successfully, but these errors were encountered: