Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shop=mall dot at z17-19 #2651

Closed
daganzdaanda opened this issue May 31, 2017 · 2 comments · Fixed by #2655
Closed

shop=mall dot at z17-19 #2651

daganzdaanda opened this issue May 31, 2017 · 2 comments · Fixed by #2655

Comments

@daganzdaanda
Copy link

I just noticed a big fat dot on z18, that turned out to be a mall: http://www.openstreetmap.org/node/380498034
It works on ways, too: https://www.openstreetmap.org/way/126248046

It seems as if the name still shows until z15 or z16, but then at z17 the generic dot takes over and gets bigger for z18 and z19. The style of the dot is a bit strange, too - it has a black border.
Possibly this was introduced with #2589
The black outline is discussed there and @math1985 had adressed that issue. Maybe malls were overlooked?

I think we should not switch from a red name without dot to a pink dot without name. So how to make it more consistent?
Do we have any other names in red? Are malls worth a special treatment?
Should we add an icon (see #2276) to the name from z15 and keep it until z19?
Or return to the previous state? (IIRC, malls only had the red text and no icon.)

@matthijsmelissen
Copy link
Collaborator

Correct, this is a bug that I introduced.

@matthijsmelissen
Copy link
Collaborator

I think we should not display a dot for malls at all (as you say, they have a red label already).

matthijsmelissen added a commit to matthijsmelissen/openstreetmap-carto that referenced this issue Jun 3, 2017
matthijsmelissen added a commit to matthijsmelissen/openstreetmap-carto that referenced this issue Jun 3, 2017
nebulon42 added a commit that referenced this issue Jun 13, 2017
Don't render malls as dots (fixes #2651)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants