Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render office=lawyer #1922

Closed
iansan5653 opened this issue Oct 25, 2015 · 27 comments · Fixed by #3163
Closed

Render office=lawyer #1922

iansan5653 opened this issue Oct 25, 2015 · 27 comments · Fixed by #3163

Comments

@iansan5653
Copy link

Currently law offices aren't rendered at all, which is a problem in areas such as this one in which an entire side of the block is law offices. They are useful and I see no reason not to render them. As for how they should be rendered, I suggest using the amenity pink styling with a lawyer scale icon. Even though they are really tagged as offices, they are more comparable to medical offices like shop=optician or amenity=dentist.

@matthijsmelissen
Copy link
Collaborator

See also #108 and #1697.

@pnorman pnorman added this to the 3.x - Needs upgrade to openstreetmap-carto.style milestone Oct 25, 2015
@ccamara
Copy link

ccamara commented Aug 22, 2016

I think that proposal should be extended to all types of offices (like office=architect or office=government). Copying from #108 :

As far as I see it, the main difference between most shop=* and office=* is that whereas the first sell goods, the latter sell services. For that reason I think that if it has been decided that shops have to be rendered because they might be of any interest, offices should be rendered as well, as they are at least as interesting as shops, if not more (I'm thinking now about government offices, which additionally may be considered of public interest).

It is quite another thing the already mentioned problems of readability, but IMHO that should be addressed later as a different issue (eg: by defining the right icons, colours and zoom levels), but that should come after displaying offices (I find this proposal a good workaround to be used in the meanwhile)

@abdeldjalil09
Copy link

abdeldjalil09 commented Dec 11, 2016

Hi,
office=* key is already in database , why you wait to re-loading the database ?

@ccamara
Copy link

ccamara commented Dec 11, 2016

I'm not sure of having understood your comment properly. We know office=* is already present in the database, but what we are asking for is that those items tagged with them should be rendered in the default map, just as any other shop. (see my reasoning above)

@abdeldjalil09
Copy link

@ccamara Because the current milestone is "Database layout change".

@matthijsmelissen
Copy link
Collaborator

You're right, I fixed the milestone.

@ccamara
Copy link

ccamara commented Dec 11, 2016

Thanks to both for noticing!

@andrzej-r
Copy link
Contributor

@abdeldjalil09, @ccamara what do you mean by:

office=* key is already in database [...]
?

In my PR (#3061) I had to use tags->'office' because I was getting errors saying there is no 'office' column in the table. Do you mean such column already exists in the main osm database and the problem was cause by our osm2pgsql setup used for testing?

Either way, tags->'office' does work, with or without the 'office' column.

@kocio-pl
Copy link
Collaborator

It probably meant that it is now available for rendering database (previously it wasn't), but this is in the form of hstore, so one has to use tags->'office', indeed.

@Tomasz-W
Copy link

Tomasz-W commented Mar 13, 2018

Do you think #3061 resolves this issue? I don't have an idea for lawyer symbol, and I think that generic dot would be enough. Of course I'm open to any propositions and ready to try to design proper icon. What do you think?

@kocio-pl
Copy link
Collaborator

For a long time already I've been thinking of generic section sign (§) - we use such symbols rarely, but I think this is the proper case (pun intended 😄 ).

@Tomasz-W
Copy link

Simple section sign from https://commons.wikimedia.org/wiki/File:Section_sign.svg put into 14x14 matrix:

office lawyer

Gist: https://gist.github.com/Tomasz-W/45897e9464e10201426f603535b180b7

@iansan5653
Copy link
Author

iansan5653 commented Mar 16, 2018

What if we used a set of scales (⚖️) which are traditionally used to represent the law? Example: https://commons.wikimedia.org/wiki/File:Balanced_scales.svg

@kocio-pl
Copy link
Collaborator

@lakedistrictOSM
Copy link

I don't associate the section sign symbol with law and therefore wouldn't interpret it as a lawyer's office if I saw it on a map.

@kocio-pl
Copy link
Collaborator

There are example like this symbol of a law book:

https://www.shutterstock.com/image-vector/law-book-statute-paragraph-sign-icon-635919041

@lakedistrictOSM
Copy link

Perhaps it's a standard symbol for law in some countries but not all, feedback from people in other parts of the world is needed.

Scales of justice (courthouse icon but one side higher than the other) or gavel (judge's hammer) might be better icon designs.

@kocio-pl
Copy link
Collaborator

For me the scales and gavel are more related to the act of judging than law in general, while section sign is not that specific, but that's interesting to know what other people think about it. Comments?

@dieterdreist
Copy link

dieterdreist commented Mar 17, 2018 via email

@iansan5653
Copy link
Author

iansan5653 commented Mar 18, 2018 via email

@Tomasz-W
Copy link

For me, balanced scale is a symbol of justice, and "justice places" are courthouses. Section sign is taken from law books, which lawyers use everyday for their work, so it's more intuitive, I think.

@1ec5
Copy link

1ec5 commented Mar 19, 2018

How about a briefcase (💼)? I think it would be more recognizable than a section sign, clever as a section sign would be. If a briefcase could be confused with other kinds of offices, that would still be better than conflating law offices with courthouses.

@kocio-pl
Copy link
Collaborator

We already use something close for bag shops (and the briefcase can be related to any kind of office IMO):

https://github.com/gravitystorm/openstreetmap-carto/blob/master/symbols/shop/bag.svg

@turnsole80
Copy link

turnsole80 commented Mar 19, 2018 via email

@dieterdreist
Copy link

dieterdreist commented Mar 19, 2018 via email

@Tomasz-W
Copy link

Is blue dot enough or do we want to use blue section sign here? What is your opinion?

1

@kocio-pl
Copy link
Collaborator

Could someone test a blue section sign rendering? I still like this idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.