fix: fixed setScales method

demo/examples/dynamic-updates.html

@@ -83,6 +83,14 @@ <h1>Dynamic updates</h1>
             </div>
         </div>
 
+        <div class="grid">
+            <div class="container">
+                <div id="chart11"></div>
+                <button id="changeScales">Change scales</button>
+                <button id="changeScalesMinMax">Change scales min/max</button>
+            </div>
+        </div>
+
         <script>
             function randomColor(a = 1) {
                 const r = Math.floor(Math.random() * 255);
@@ -491,6 +499,37 @@ <h1>Dynamic updates</h1>
                     ],
                 });
             };
+
+
+            const yagr11 = new Yagr(chart11, {
+                title: {text: 'Change scales'},
+                timeline: [1, 2, 3, 4],
+                series: [
+                    {
+                        data: [1, 2, 3, 4],
+                        color: 'green',
+                    },
+                ],
+                scales: {
+                    y: {min: 0, max: 10}
+                }
+            });
+
+            window.changeScales.onclick = () => {
+                yagr11.setConfig({
+                    scales: {
+                        y: {min: 0, max: 5, range: () => ([0, 5])}
+                    }
+                });
+            };
+
+            window.changeScalesMinMax.onclick = () => {
+                yagr11.setConfig({
+                    scales: {
+                        y: {min: -10, max: 20, range: () => ([0, 5])}
+                    }
+                });
+            };
         </script>
     </body>
 </html>

src/YagrCore/mixins/batch-updates.ts

@@ -92,7 +92,8 @@ export class BatchMixin<T extends MinimalValidConfig> {
                 this.transformSeries();
             })
             .inStage('uplot', () => {
-                this.uplot.destroy();
+                // uplot may be undefined if chart is not rendered yet, but got update
+                this.uplot?.destroy();
                 this.uplot = new UPlot(this.options, this.series, this.initRender);
                 this.plugins.legend?.redraw();
             })

src/YagrCore/mixins/dynamic-updates.ts

@@ -1,11 +1,11 @@
-import type {MinimalValidConfig, RawSerieData, SupportedLocales, YagrConfig, YagrTheme} from '../types';
+import type {MinimalValidConfig, RawSerieData, Scale, SupportedLocales, YagrConfig, YagrTheme} from '../types';
 import Yagr from '..';
 
 import i18n from '../locale';
 import {DEFAULT_X_SCALE, DEFAULT_Y_SCALE} from '../defaults';
 import {overrideSeriesInUpdate, configureSeries} from '../utils/series';
 import {getRedrawOptionsForAxesUpdate, updateAxis} from '../utils/axes';
-import {Paths, containsOnly, deepIsEqual, get} from '../utils/common';
+import {Paths, deepIsEqual, get} from '../utils/common';
 import {Batch} from './batch-updates';
 
 interface UpdateOptions {
@@ -101,33 +101,34 @@ function setVisibleImpl(yagr: Yagr, lineId: string | null, show: boolean, update
 
 function setScalesImpl(yagr: Yagr, scales: YagrConfig['scales'], batch: Batch) {
     let stackingIsChanged = false;
-    let typeIsChanged = false;
     let normalizationIsChanged = false;
 
     Object.entries(scales).forEach(([scaleName, scaleConfig]) => {
         const scale = yagr.config.scales[scaleName];
 
         if (scale) {
-            const {stacking, type} = scale;
-            const {stacking: newStacking, type: newType} = scaleConfig;
+            const {stacking} = scale;
+            const {stacking: newStacking} = scaleConfig;
 
             if (stacking !== newStacking) {
                 stackingIsChanged = true;
             }
 
-            if (type !== newType) {
-                typeIsChanged = true;
-            }
-
             if (scaleConfig.normalize !== scale.normalize || scaleConfig.normalizeBase !== scale.normalizeBase) {
                 normalizationIsChanged = true;
             }
         }
     });
 
-    const isChangingOnlyMinMax = Object.values(scales).every((scaleConfig) =>
-        containsOnly(scaleConfig as Record<string, unknown>, ['min', 'max']),
-    );
+    const isChangingOnlyMinMax = Object.entries(scales).every(([key, scaleConfig]: [string, Scale]) => {
+        const cfg = yagr.config.scales[key];
+
+        const {min: pMin, max: pMax, ...pRest} = cfg;
+        const {min: nMin, max: nMax, ...nRest} = scaleConfig;
+        const isChangedSomething = deepIsEqual(nRest, pRest) === false;
+
+        return !isChangedSomething && (pMin !== nMin || pMax !== nMax);
+    });
 
     const isChangingXAxis = Object.keys(scales).includes(DEFAULT_X_SCALE);
 
@@ -150,13 +151,8 @@ function setScalesImpl(yagr: Yagr, scales: YagrConfig['scales'], batch: Batch) {
         batch.reinit = true;
     }
 
-    if (typeIsChanged) {
-        batch.reopt = true;
-        batch.recalc = true;
-    }
-
     yagr.config.scales = scales;
-    batch.redraw = [true, true];
+    batch.reinit = true;
 }
 
 function isChanged(oldConfig: YagrConfig, newConfig: Partial<YagrConfig>) {
@@ -223,7 +219,7 @@ function setConfigImpl(yagr: Yagr, batch: Batch, newConfig: Partial<YagrConfig>,
         yagr.setScales(newConfig.scales);
     }
 
-    const isChangedSeries = areSeriesChanged(yagr.config.series, newConfig.series);
+    const isChangedSeries = Boolean(newConfig.series) && areSeriesChanged(yagr.config.series, newConfig.series);
 
     if (isChangedSeries) {
         batch.redrawLegend = true;

src/YagrCore/utils/common.ts

@@ -399,10 +399,6 @@ export const html = (
     return el;
 };
 
-export function containsOnly(obj: Record<string, unknown>, keys: string[]) {
-    return Object.keys(obj).every((key) => keys.includes(key));
-}
-
 type Prev = [never, 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, ...0[]];
 type Join<K, P> = K extends string | number
     ? P extends string | number