feat: upgrade trino autocomplete #247
Conversation
|
|
||
| # Intellij IDES add weird token files that we don't use | ||
| **/grammar/*.tokens |
There was a problem hiding this comment.
IDK how to fix it and have the antlr syntax highlighting, decided to just ignore this file
|
|
||
| statements | ||
| : statement SEMICOLON_? | ||
| | statement SEMICOLON_ statements |
There was a problem hiding this comment.
Current Trino client doesn't work with semicolons and multiple statements, so I've removed it from our autocomplete for now for better UX
There was a problem hiding this comment.
Why do we have special logic for Trino for this? ClickHouse also doesn't support multiqueries but we have it in autocomplete
I don't think our autocomplete library should be concerned with how our websql code works, it should be independent
Also when we soon support this we will have to add it again
We should just throw error on multiple query execution like we do in ClickHouse
There was a problem hiding this comment.
I agree with Robert, need to discuss this decision
There was a problem hiding this comment.
We've discussed it. Decided to go for better UX for now
| : rootQuery # statementDefault | ||
| | USE_ schema = identifier # use | ||
| | USE_ catalog = identifier DOT_ schema = identifier # use | ||
| | CREATE_ CATALOG_ (IF_ NOT_ EXISTS_)? catalog = identifier USING_ connectorName = identifier ( |
There was a problem hiding this comment.
Basically I've splitted a bunch of simple identifiers to tableIdentifier, schemaIdentifier, catalogIdentifier to have a simple autocomplete
|
|
||
| viewIdentifier | ||
| : tableIdentifier | ||
| ; |
There was a problem hiding this comment.
Trino-client doesn't allow for USE statements, so we are forced to always give a fully qualified name like catalog.schema.table. This will greatly improve UX, because otherwise user will need to get an error from back end
No description provided.