refactor: migrate generic/jison/create_view test to typescript

src/parsing/index.ts

@@ -18,9 +18,7 @@ export interface ParseResult {
         onlyTables?: boolean;
     };
     suggestColumns?: ColumnSuggestion;
-    suggestAggregateFunctions?: {
-        tables: Table[],
-    };
+    suggestAggregateFunctions?: AggregateFunctionsSuggestion;
     suggestAnalyticFunctions?: unknown;
     suggestColRefKeywords?: unknown;
     suggestColumnAliases?: ColumnAliasSuggestion[];
@@ -87,6 +85,10 @@ export type StatementPart =
         qualified: boolean,
     };
 
+export interface AggregateFunctionsSuggestion {
+    tables: Table[],
+}
+
 export interface ColumnSuggestion {
     source?: string;
     tables: Table[];

src/parsing/parsers/generic/jison/create/create_common.test.ts

@@ -11,16 +11,4 @@ test('should suggest CREATE', () => {
 
     const suggestion: KeywordSuggestion = { value: 'CREATE', weight: -1 };
     expect(parseResult.suggestKeywords).toContainEqual(suggestion);
-})
-
-// TODO: remove, because it's being tested in other tests
-test('should suggest CREATE objects', () => {
-    const parseResult = parseGenericSql('CREATE ', '');
-
-    expect(parseResult.errors).toBeUndefined();
-
-    const suggestions: KeywordSuggestion[] = [
-        { value: 'VIEW', weight: -1 },
-    ];
-    expect(parseResult.suggestKeywords).toEqual(expect.arrayContaining(suggestions))
 })

src/parsing/parsers/generic/jison/create/create_view.test.ts

@@ -0,0 +1,60 @@
+import {
+    KeywordSuggestion,
+    parseGenericSql, parseGenericSqlWithoutCursor,
+} from '../../../../index';
+import {expect, test} from '@jest/globals';
+
+test('should suggest creating VIEW', () => {
+    const parseResult = parseGenericSql('CREATE ', '');
+
+    expect(parseResult.errors).toBeUndefined();
+
+    const suggestions: KeywordSuggestion[] = [
+        { value: 'VIEW', weight: -1 },
+    ];
+    expect(parseResult.suggestKeywords).toEqual(expect.arrayContaining(suggestions))
+})
+
+test('should suggest IF NOT EXISTS', () => {
+    const parseResult = parseGenericSql('CREATE VIEW ', '');
+
+    expect(parseResult.errors).toBeUndefined();
+
+    const suggestions: KeywordSuggestion[] = [
+        { value: 'IF NOT EXISTS', weight: -1 },
+    ];
+    expect(parseResult.suggestKeywords).toEqual(expect.arrayContaining(suggestions))
+})
+
+test('should suggest AS and COMMENT', () => {
+    const parseResult = parseGenericSql('CREATE VIEW test_view ', '');
+
+    expect(parseResult.errors).toBeUndefined();
+
+    const suggestions: KeywordSuggestion[] = [
+        { value: 'AS', weight: 1 },
+        { value: 'COMMENT', weight: 3 },
+    ];
+    expect(parseResult.suggestKeywords).toEqual(expect.arrayContaining(suggestions))
+})
+
+test('should suggest SELECT', () => {
+    const parseResult = parseGenericSql('CREATE VIEW test_view AS ', '');
+
+    expect(parseResult.errors).toBeUndefined();
+
+    const suggestions: KeywordSuggestion[] = [
+        { value: 'SELECT', weight: -1 },
+    ];
+    expect(parseResult.suggestKeywords).toEqual(expect.arrayContaining(suggestions))
+})
+
+test('should not report errors on full CREATE VIEW statement', () => {
+    const parseResult = parseGenericSqlWithoutCursor('CREATE VIEW test_view COMMENT "test" AS SELECT test_field, test_field_2 FROM test_table;');
+    expect(parseResult.errors).toBeUndefined();
+})
+
+test('should not report errors on full CREATE VIEW statement without comment', () => {
+    const parseResult = parseGenericSqlWithoutCursor('CREATE VIEW test_view AS SELECT test_field, test_field_2 FROM test_table;');
+    expect(parseResult.errors).toBeUndefined();
+})