feat(Button)!: allow HTML attributes as "top-level" props #2015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amje
requested review from
ogonkov,
korvin89,
IsaevAlexandr,
Raubzeug,
kseniya57,
Marginy605,
Ruminat,
jhoncool and
ValeraS
as code owners
|
Preview is ready. |
|
Visual Tests Report is ready. |
jhoncool
approved these changes
Dec 24, 2024
korvin89
approved these changes
Dec 26, 2024
| qa, | ||
| }, | ||
| ...props |
There was a problem hiding this comment.
There are no props anyway, so I decided to keep it simple. There are already commonProps, extraProps in the file. Adding restProps will be more confusing
amje
added a commit
that referenced
this pull request
Dec 28, 2024
amje
added a commit
that referenced
this pull request
Jan 9, 2025
amje
added a commit
that referenced
this pull request
Jan 16, 2025
amje
added a commit
that referenced
this pull request
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the successor of #1594