refactor(Toaster): fix incompatibility of different Toaster APIs #1987
Conversation
|
Preview is ready. |
|
Visual Tests Report is ready. |
icekimi23
force-pushed
the
refactor/Toaster
branch
from
9d04f6b to
e788ad6
Compare
| remove(name: string) { | ||
| this.toasts = removeToast(this.toasts, name); | ||
|
|
||
| this.notify(); | ||
| } |
There was a problem hiding this comment.
I think we need to maintain destroy() method, let it call removeAll underneath
|
|
||
| import {ToasterContext} from './ToasterContext'; | ||
| import {ToastsContext} from './ToastsContext'; | ||
|
|
||
| type Props = React.PropsWithChildren<{}>; | ||
| type Props = React.PropsWithChildren<{ | ||
| toaster: ToasterSingleton; |
There was a problem hiding this comment.
This is definitely breaking change, please change target branch to next
| private notify() { | ||
| for (const listener of this.listeners) { | ||
| listener(this.toasts); | ||
| } | ||
| } |
There was a problem hiding this comment.
Please separate subscribe pattern from Toaster class to separate base class EventEmitter
|
Please describe all breaking changes in PR description |
icekimi23
force-pushed
the
refactor/Toaster
branch
from
e788ad6 to
154760e
Compare
icekimi23
requested review from
IsaevAlexandr,
Raubzeug,
Arucard89,
mournfulCoroner,
DakEnviy,
zamkovskaya,
kseniya57,
Marginy605,
Ruminat,
Estasie,
goshander,
axtk,
Lunory and
jhoncool
as code owners
icekimi23
force-pushed
the
refactor/Toaster
branch
from
154760e to
b629735
Compare
|
@ogonkov I have updated PR, check it once again, please, when you can. I removed Singleton pattern from Toaster (in separate commit), I think it is more clear and flexible to return new object every time, with this behaviour users can create multiple Providers for toasts if they want. But it would be nice to hear your opinion:) |
PR is made to implement this RFC gravity-ui/rfc#15
Breaking changes:
ToasterProvider now requires a mandatory
toasterproperty, where you must pass an instance of theToasterclass.The
Toasterclass is now responsible for managing toast state but no longer handles rendering. As a result, there is no need to callToaster.injectReactDOMClient(ReactDOMClient)anymore.Calling
new Toaster()now returns a new object each time. If you want to use toasts within React through theuseToaster()hook or use theToasterobject directly outside React (e.g., in Redux side effects, etc.) while ensuring that toasts appear in a same screen area without overlapping, you need to make sure that the object passed toToasterProviderand the one used outside React is the same instance.To get a single shared instance of
Toaster, you can import it from@gravity-ui/uikit/toaster-singleton.The
toaster-singleton-react-18.jsfile no longer exists, but it is unnecessary since there is no longer any specific dependency on a particular React version.