test(Avatar): add smoke visual tests #1771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview is ready. |
|
Visual Tests Report is ready. |
itwillwork
force-pushed
the
add-smoke-tests/Avatar
branch
from
c716e30 to
bddb8cd
Compare
DakEnviy
requested changes
Dec 26, 2024
| title: titleCases, | ||
| } as const; | ||
|
|
||
| smokeTest('smoke, with image', async ({mount, expectScreenshot}) => { |
There was a problem hiding this comment.
It looks like you can write just with image here. smoke prefix is already included in smokeTest function
| }); | ||
| }); | ||
|
|
||
| smokeTest('smoke', async ({mount, expectScreenshot}) => { |
There was a problem hiding this comment.
with text instead of smoke
| export const viewCases: Cases<AvatarProps['view']> = ['filled', 'outlined']; | ||
| export const backgroundColorCases: Cases<AvatarProps['backgroundColor']> = ['darkblue']; | ||
| export const borderColorCases: Cases<AvatarProps['borderColor']> = ['tomato']; | ||
| export const titleCases: Cases<AvatarProps['title']> = ['Title']; |
There was a problem hiding this comment.
Try to compose it into one object
itwillwork
force-pushed
the
add-smoke-tests/Avatar
branch
from
706c777 to
326a377
Compare
DakEnviy
approved these changes
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.