ci(storybook): make tests mandatory #1543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Playwright Test Component is ready. |
|
Preview is ready. |
amje
changed the title
amje
requested changes
Apr 23, 2024
| run: | | ||
| npx concurrently -k -s first -n "SB,TEST" -c "magenta,blue" \ | ||
| "npx http-server storybook-static --port 7007 --silent" \ | ||
| "npx wait-on http://127.0.0.1:7007 && npm run test-storybook" |
There was a problem hiding this comment.
Let's reuse PR_PREVIEW_URL env here
amje
approved these changes
Apr 23, 2024
Arucard89
pushed a commit
that referenced
this pull request
May 8, 2024
Co-authored-by: Kezhik Kyzyl-ool <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to merge #1538 first