fix(Dialog): move QA props to DialogOwnProps (#1691)

gravity-ui · Jul 1, 2024 · fc33ba7 · fc33ba7
1 parent 8af4f99
commit fc33ba7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/components/Dialog/Dialog.tsx b/src/components/Dialog/Dialog.tsx
@@ -17,7 +17,7 @@ import './Dialog.scss';
 
 const b = block('dialog');
 
-interface DialogOwnProps {
+interface DialogOwnProps extends QAProps {
     open: boolean;
     children: React.ReactNode;
     onEscapeKeyDown?: ModalProps['onEscapeKeyDown'];
@@ -52,7 +52,7 @@ interface DialogDefaultProps {
 }
 
 export type DialogProps = DialogOwnProps & Partial<DialogDefaultProps>;
-type DialogInnerProps = DialogOwnProps & DialogDefaultProps & QAProps;
+type DialogInnerProps = DialogOwnProps & DialogDefaultProps;
 
 export class Dialog extends React.Component<DialogInnerProps> {
     static defaultProps: DialogDefaultProps = {

diff --git a/src/components/Dialog/__stories__/DialogShowcase.tsx b/src/components/Dialog/__stories__/DialogShowcase.tsx
@@ -67,6 +67,7 @@ function OtherDialog() {
                 hasCloseButton
                 keepMounted
                 onEnterKeyDown={handleApply}
+                qa="darthVader"
                 onTransitionEntered={() => {
                     selectRef?.current?.focus();
                     setTimeout(() => setOpenSelect(true), 0);