feat(Table): add vertical alignment #91
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview is ready. |
|
Also it might be a good idea to make verticalAlign: 'top' default? |
beliarh
reviewed
Dec 18, 2024
src/components/Table/Table.scss
Outdated
Comment on lines
43
to
54
| &_vertical-align { | ||
| &_top { | ||
| vertical-align: top; | ||
| } | ||
|
|
||
| &_center { | ||
| vertical-align: middle; | ||
| } | ||
|
|
||
| &_bottom { | ||
| vertical-align: bottom; | ||
| } |
There was a problem hiding this comment.
vertical-align won't help in case of enabled virtualization due to display: flex style
There was a problem hiding this comment.
Thanks, I was suspecting something might go wrong with virtualization, I'll look into it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds vertical alignment for table body rows just like in the uikit's table: https://preview.gravity-ui.com/uikit/?path=/story/components-data-display-table--default.
As for my investigation, horizontal alignment requires many wrappers for tanstack's types, so I suggest to implement it in another PR