feat: use opentelemetry library for tracing #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resure
reviewed
Nov 11, 2024
Merged
|
It will be reviewed after #61 |
jigetus
force-pushed
the
otel-tracing
branch
from
8afdaa1 to
23be439
Compare
| logFunction: (extra: Dict | undefined, message: string) => void, | ||
| ): DiagLogFunction { | ||
| return (message, ...args) => { | ||
| const data = args.reduce((acc: Record<string, any>, cur, index) => { |
There was a problem hiding this comment.
Suggested change
| const data = args.reduce((acc: Record<string, any>, cur, index) => { | |
| const data = args.reduce((acc: Record<string, unknown>, cur, index) => { |
| return (message, ...args) => { | ||
| const data = args.reduce((acc: Record<string, any>, cur, index) => { | ||
| if (typeof cur === 'object' && !Array.isArray(cur)) { | ||
| acc = { |
There was a problem hiding this comment.
It would be nice to add
"no-param-reassign": [
"warn",
{
"props": true,
"ignorePropertyModificationsFor": ["acc"]
}
]
to the .eslintrc
There was a problem hiding this comment.
I refactored the code and now it's without warnings
src/lib/tracing/init-tracing.ts
Outdated
| traceExporter: | ||
| appTracingSpanExporter || | ||
| new OTLPTraceExporter({ | ||
| url: appTracingCollectorEndpoint || DEFAULT_COLLECTOR_HOST, |
There was a problem hiding this comment.
I think DEFAULT_COLLECTOR_HOST is redundant.
url is optional and can be omitted - default is http://localhost:4318/v1/traces
https://www.npmjs.com/package/@opentelemetry/exporter-trace-otlp-http
|
@melikhov-dev I updated the pull request, take a look |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en.
close #2