feat: add ClickHouse telemetry (AppContext.stats) #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ma-efremoff
force-pushed
the
ma-efremoff/stats
branch
3 times, most recently
from
5cfd65f to
21fc9f3
Compare
resure
reviewed
Apr 6, 2023
|
|
||
| export function prepareBatchedQueue({ | ||
| fn, | ||
| logError = console.error, |
There was a problem hiding this comment.
let's surpress eslint warnings here, since usage of console.error is intended
ma-efremoff
force-pushed
the
ma-efremoff/stats
branch
from
21fc9f3 to
7354357
Compare
resure
reviewed
Apr 14, 2023
src/types.ts
Outdated
| @@ -16,6 +16,15 @@ export interface AppConfig { | |||
| appTracingSampler?: {type: string; param: number}; | |||
| appTracingAgentHost?: string; | |||
| appTracingAgentPort?: number; | |||
|
|
|||
| telemetryChHost?: string; | |||
There was a problem hiding this comment.
Maybe we should add app prefix too here?
ma-efremoff
force-pushed
the
ma-efremoff/stats
branch
from
7354357 to
959bcf2
Compare
resure
changed the title
ma-efremoff
force-pushed
the
ma-efremoff/stats
branch
from
959bcf2 to
9eabd6f
Compare
resure
approved these changes
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.