fix: initial value #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
NasgulNexus
commented
May 11, 2023
NasgulNexus
commented
- In the controller, instead of the initial value, there will be a value.
- From the final form we pull out the initial value and value.
|
Preview is ready. |
bocembocem
requested changes
May 12, 2023
| @@ -85,7 +85,7 @@ export const DynamicField: React.FC<DynamicFieldProps> = ({ | |||
| name={name} | |||
| parentOnChange={null} | |||
| parentOnUnmount={null} | |||
| initialValue={_.get(tools.initialValue, name)} | |||
| value={_.get(tools.values, name)} | |||
There was a problem hiding this comment.
U need to take values from store, not from tools
| @@ -71,18 +73,19 @@ export const useField = <Value extends FieldValue, SpecType extends Spec>({ | |||
| } | |||
|
|
|||
| const error = validate?.(value); | |||
| const isDiffentValues = !_.isEqual(value, initialValue); | |||
There was a problem hiding this comment.
*diffeREnt
Prefix is better to use for functions
You're checking dirty here, let's give a name for variable dirty too
| pristine: false, | ||
| touched: false, | ||
| modified: isDiffentValues, | ||
| pristine: isDiffentValues, |
There was a problem hiding this comment.
U can't use isEqual to check for pristine, only ===
| @@ -28,36 +32,42 @@ export const useStore = (name: string) => { | |||
| const tools = React.useMemo( | |||
| () => ({ | |||
| initialValue: store.initialValue, | |||
| values: store.values, | |||
There was a problem hiding this comment.
No need to include values in tools
| onChange: (name: string, value: FieldValue, errors?: Record<string, ValidateError>) => | ||
| setStore((store) => ({ | ||
| ...store, | ||
| values: _.set({...store.values}, name, _.clone(value)), | ||
| errors: errors || {}, | ||
| })), | ||
| onUnmount: (name: string) => | ||
| onUnmount: (name: string) => { |
There was a problem hiding this comment.
Pointless changes, let's remove back
|
|
||
| export interface DynamicFormsContext { | ||
| config: DynamicFormConfig; | ||
| Monaco?: React.ComponentType<MonacoEditorProps>; | ||
| tools: { | ||
| initialValue: FieldObjectValue; | ||
| initialValue: FieldValue; | ||
| values: FieldValue; |
bocembocem
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.