Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: increase max options for CardOneOf #197

Merged
merged 1 commit into from
Apr 23, 2024
+6 −2
Merged

feat: increase max options for CardOneOf #197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/lib/kit/hooks/useOneOf/useOneOf.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,13 @@
&__card {
display: flex;

& > :first-child {
& > * {
margin-right: 8px;
}

& > :last-child {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

& > *:not(:last-child) {
            margin-right: 8px;
        }
        ``` 
let's make it look better

margin-right: 0;
}
}

&__checkbox {
Expand Down
2 changes: 1 addition & 1 deletion src/lib/kit/hooks/useOneOf/useOneOf.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ export const useOneOf = ({props, onTogglerChange}: UseOneOfParams) => {
);

const togglerType = React.useMemo(() => {
if (spec.viewSpec.oneOfParams?.toggler === 'card' && options.length < 3) {
if (spec.viewSpec.oneOfParams?.toggler === 'card' && options.length < 4) {
return 'card';
}

Expand Down
Loading