feat(ObjectBase): add inline variant #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview is ready. |
DakEnviy
force-pushed
the
object-inline
branch
from
653ff92 to
3c5ba43
Compare
NasgulNexus
reviewed
Sep 1, 2023
|
|
||
| & > div { | ||
| flex: auto; | ||
| margin-right: 8px; |
src/stories/ObjectInline.stories.tsx
Outdated
|
|
||
| const value = {gender: 'other', name: 'Foo'}; | ||
|
|
||
| const excludeOptions = ['description', 'viewSpec.type', 'viewSpec.oneOfParams']; |
There was a problem hiding this comment.
need to add 'viewSpec.placeholder'
| import {InputPreview} from './components'; | ||
|
|
||
| export default { | ||
| title: 'Object/Inline', |
There was a problem hiding this comment.
I would rename it to objectInline - as objectValue
and accordingly in the config object_inline
There was a problem hiding this comment.
But for ObjectBase the name is base. I named it according to this logic.
bocembocem
requested changes
Sep 4, 2023
|
|
||
| .#{$ns}object-base { | ||
| &__content { | ||
| &_inline { |
There was a problem hiding this comment.
let's make the same width for each child input
| @@ -49,18 +64,24 @@ export const ObjectBase: ObjectIndependentInput = ({spec, name, Layout, ...restP | |||
| ); | |||
|
|
|||
| const content = React.useMemo(() => { | |||
| if (!_.isObjectLike(spec.properties) || !Object.keys(spec.properties || {}).length) { | |||
| if ( | |||
| !spec.properties || | |||
There was a problem hiding this comment.
it seems this check is not needed
There was a problem hiding this comment.
This check is required for typings. Otherwise we have to make type casting
DakEnviy
force-pushed
the
object-inline
branch
from
3c5ba43 to
ca27407
Compare
DakEnviy
force-pushed
the
object-inline
branch
from
845682e to
0d3e393
Compare
bocembocem
approved these changes
Sep 5, 2023
NasgulNexus
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.