Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix settings.loadLocale #12

Merged
merged 1 commit into from
Feb 1, 2023
Merged

fix: fix settings.loadLocale #12

merged 1 commit into from
Feb 1, 2023

Conversation

korvin89
Copy link
Collaborator

@korvin89 korvin89 commented Jan 31, 2023 •
edited
Loading

import produces this output:

b = "dayjs/locale/" + localeInLowerCase + ".js”; 
require(b);

require produces this output:

require("dayjs/locale/" + localeInLowerCase + ".js”);

the first one ruines webpack

@korvin89 korvin89 requested a review from amje January 31, 2023 22:12
@korvin89 korvin89 merged commit 753668b into main Feb 1, 2023
@korvin89 korvin89 deleted the fix-locales-import branch February 1, 2023 08:19
@gravity-ui-bot gravity-ui-bot mentioned this pull request Feb 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amje amje amje approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@korvin89 @amje