Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: group render props typing #193

Merged
merged 1 commit into from
Sep 17, 2024
Merged

fix: group render props typing #193

merged 1 commit into from
Sep 17, 2024

Conversation

flops
Copy link
Collaborator

@flops flops commented Sep 16, 2024

No description provided.

@gravity-ui-bot
Copy link
Contributor

Preview is ready.

@@ -36,6 +36,7 @@ export interface DashkitGroupRenderProps {
editMode: boolean;
items: ConfigItem[];
layout: ConfigLayout[];
context: any;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No other variants?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really for now, only one is to rewrite all types to Generic

@flops flops added this pull request to the merge queue Sep 17, 2024
Merged via the queue into main with commit 4ca030b Sep 17, 2024
3 checks passed
@flops flops deleted the group-render-context-prop branch September 17, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants