fix: fix after review

gravity-ui · Jan 23, 2023 · ecb5166 · ecb5166
1 parent a923863
commit ecb5166
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 7 deletions.
diff --git a/src/plugins/indicator/renderer/IndicatorWidget.tsx b/src/plugins/indicator/renderer/IndicatorWidget.tsx
@@ -18,21 +18,16 @@ const IndicatorWidget = React.forwardRef<ChartKitWidgetRef | undefined, ChartKit
         const {
             onLoad,
             onRender,
-            onChartLoad,
             formatNumber,
             data: {data = [], defaultColor},
         } = props;
 
         React.useLayoutEffect(() => {
             // TODO: swap to onRender after https://github.com/gravity-ui/chartkit/issues/33
             onLoad?.();
-            onRender?.(); // TODO renderTime ?
+            onRender?.(); // TODO renderTime
         });
 
-        React.useLayoutEffect(() => {
-            onChartLoad?.({widget: null});
-        }, []);
-
         if (isEmpty(data)) {
             throw new ChartKitError({
                 code: CHARTKIT_ERROR_CODE.NO_DATA,

diff --git a/src/types/index.ts b/src/types/index.ts
@@ -52,7 +52,7 @@ export type ChartKitProps<T extends ChartKitType> = {
      * called on mount
      * @param data
      */
-    onChartLoad?: (data?: ChartKitOnChartLoad) => void;
+    onChartLoad?: (data?: ChartKitOnChartLoad) => void | never;
 
     onError?: ChartKitOnError;
 } & {[key in keyof Omit<ChartKitWidget[T], 'data' | 'widget'>]: ChartKitWidget[T][key]};